From 097faead4a46e0faee98684ce128472774fe9933 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Tue, 4 Feb 2025 12:35:52 +0100 Subject: [PATCH] package/network-manager: needs headers >= 4.20 Since the bump of NetworkManager to version 1.50 in Buildroot commit 489d1f924979f7a94008e887393702e3c3663705, it uses the NETLINK_GET_STRICT_CHK netlink macro, which only appeared in Linux 4.20, so let's add a dependency on headers >= 4.20. This has been detected by our tests.package.test_python_sdbus_networkmanager.TestPythonPy3SdbusNetworkmanager at: https://gitlab.com/buildroot.org/buildroot/-/jobs/9019173666 NetworkManager is not selected by any package, so only fixing package/network-manager/Config.in is necessary. Signed-off-by: Thomas Petazzoni --- package/network-manager/Config.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in index 1d9a02c1d3..de7989a9c5 100644 --- a/package/network-manager/Config.in +++ b/package/network-manager/Config.in @@ -4,7 +4,8 @@ config BR2_PACKAGE_NETWORK_MANAGER depends on BR2_USE_MMU # dbus depends on BR2_PACKAGE_HAS_UDEV depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 - depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6 + # We need NETLINK_GET_STRICT_CHK + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_20 depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 depends on BR2_USE_WCHAR # libglib2 @@ -59,10 +60,10 @@ config BR2_PACKAGE_NETWORK_MANAGER_OVS This option enables support for OpenVSwitch endif -comment "NetworkManager needs udev /dev management and a glibc or musl toolchain w/ headers >= 4.6, dynamic library, wchar, threads, gcc >= 4.9" +comment "NetworkManager needs udev /dev management and a glibc or musl toolchain w/ headers >= 4.20, dynamic library, wchar, threads, gcc >= 4.9" depends on BR2_USE_MMU depends on !BR2_PACKAGE_HAS_UDEV || \ - !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6 || \ + !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_20 || \ !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL) || \ BR2_STATIC_LIBS || \ !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \