From 33947d6b5ac168854855d0cc1db18791e45c4a82 Mon Sep 17 00:00:00 2001 From: Julien Olivain Date: Tue, 21 Oct 2025 18:27:46 +0200 Subject: [PATCH] support/testing: python-scp: fix test sample script MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When the test was introduced in [1], a comparison of the source and the destination file was added, with a typo (the method ".cmp" name is missing). The test is failing with error such as in [2]: Traceback (most recent call last): File "/root/sample_python_scp.py", line 15, in assert filecmp("/etc/hostname", "/tmp/hostname") ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: 'module' object is not callable This commit fixes that. [1] https://gitlab.com/buildroot.org/buildroot/-/commit/7470587cfa9a24d3c49adc0fb6cc60512907f31a [2] https://gitlab.com/buildroot.org/buildroot/-/jobs/11781378510 Cc: Alexis Lothoré Signed-off-by: Julien Olivain --- support/testing/tests/package/sample_python_scp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/testing/tests/package/sample_python_scp.py b/support/testing/tests/package/sample_python_scp.py index c986a27f0b..5df3ae24d8 100644 --- a/support/testing/tests/package/sample_python_scp.py +++ b/support/testing/tests/package/sample_python_scp.py @@ -12,4 +12,4 @@ ssh_client.connect('127.0.0.1', username='root') scp_client = SCPClient(ssh_client.get_transport()) scp_client.get("/etc/hostname", "/tmp/hostname") -assert filecmp("/etc/hostname", "/tmp/hostname") +assert filecmp.cmp("/etc/hostname", "/tmp/hostname")