From 33c09c71d57986dc58e20dd8487d07f052178cd7 Mon Sep 17 00:00:00 2001 From: Bernd Kuhls Date: Sun, 25 Jan 2026 11:45:01 +0100 Subject: [PATCH] package/netdata: needs C++ Buildroot commit 9cfcd906cff299ef83b48681e50bcef9df124ad4 bumped the package from 1.33.1 to 1.37.1. Upstream changed the optional C++ support into a mandatory dependency with commit https://github.com/netdata/netdata/commit/b6d2a3662dfb683e9e95203ef3b21f8e31238b06 added to version 1.35.0 causing build errors with toolchains without C++ support: GEN netdatacli /bin/sh: line 1: no: command not found make[3]: *** [Makefile:5502: netdatacli] Error 127 Fixes: https://autobuild.buildroot.org/results/7084a73d5727a86ca55eda3d1f01ea4d5b8ecf65/ Signed-off-by: Bernd Kuhls Reviewed-by: Michael Cullen Signed-off-by: Peter Korsgaard --- package/netdata/Config.in | 10 +++++----- support/testing/tests/package/test_netdata.py | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/package/netdata/Config.in b/package/netdata/Config.in index 3603eb071c..527d4d39af 100644 --- a/package/netdata/Config.in +++ b/package/netdata/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_NETDATA bool "netdata" depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL + depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_MMU # fork() depends on !BR2_STATIC_LIBS # libuv depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libuv @@ -22,22 +23,21 @@ if BR2_PACKAGE_NETDATA config BR2_PACKAGE_NETDATA_PROMETHEUS bool "prometheus remote write backend" depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS - depends on BR2_INSTALL_LIBSTDCPP # protobuf, snappy depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # protobuf select BR2_PACKAGE_PROTOBUF select BR2_PACKAGE_SNAPPY help Enable prometheus remote write backend -comment "prometheus remote write backend needs a toolchain w/ C++, gcc >= 8" - depends on !BR2_INSTALL_LIBSTDCPP || \ - !BR2_TOOLCHAIN_GCC_AT_LEAST_8 +comment "prometheus remote write backend needs a toolchain w/ gcc >= 8" + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS endif -comment "netdata needs a toolchain w/ NPTL, dynamic library, gcc >= 4.9" +comment "netdata needs a toolchain w/ C++, NPTL, dynamic library, gcc >= 4.9" depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \ + || !BR2_INSTALL_LIBSTDCPP \ || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 depends on BR2_USE_MMU depends on BR2_TOOLCHAIN_HAS_SYNC_4 diff --git a/support/testing/tests/package/test_netdata.py b/support/testing/tests/package/test_netdata.py index 6b616398d3..42bcbcdc6f 100644 --- a/support/testing/tests/package/test_netdata.py +++ b/support/testing/tests/package/test_netdata.py @@ -6,6 +6,7 @@ import infra.basetest class TestNetdata(infra.basetest.BRTest): config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \ """ + BR2_INSTALL_LIBSTDCPP=y BR2_PACKAGE_NETDATA=y BR2_TARGET_ROOTFS_CPIO=y # BR2_TARGET_ROOTFS_TAR is not set