From 4910a175b3f1f4b55ff257a75945d8ffb14a4ceb Mon Sep 17 00:00:00 2001 From: Fabrice Fontaine Date: Wed, 10 Nov 2021 18:52:18 +0100 Subject: [PATCH] utils/checkpackagelib/lib_mk.py: check DEPENDENCIES Check that {FOO}_DEPENDENCIES are never overriden in a conditional Signed-off-by: Fabrice Fontaine Reviewed-by: Ricardo Martincoski Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- utils/checkpackagelib/lib_mk.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py index 95501e5515..a304f71fd5 100644 --- a/utils/checkpackagelib/lib_mk.py +++ b/utils/checkpackagelib/lib_mk.py @@ -88,6 +88,8 @@ class OverriddenVariable(_CheckFunction): r"_SITE\s*=\s*", r"_SOURCE\s*=\s*", r"_VERSION\s*=\s*"]))) + FORBIDDEN_OVERRIDDEN = re.compile(r"^[A-Z0-9_]+({})".format("|".join([ + r"_DEPENDENCIES\s*=\s*"]))) def before(self): self.conditional = 0 @@ -123,6 +125,10 @@ class OverriddenVariable(_CheckFunction): .format(self.filename, lineno, variable), text] else: + if self.FORBIDDEN_OVERRIDDEN.search(text): + return ["{}:{}: conditional override of variable {}" + .format(self.filename, lineno, variable), + text] if variable not in self.unconditionally_set: self.conditionally_set.append(variable) return