diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py index 065733d464..1fa056cbf4 100644 --- a/utils/checkpackagelib/lib_mk.py +++ b/utils/checkpackagelib/lib_mk.py @@ -121,7 +121,7 @@ class Indent(_CheckFunction): class MissingCVEPatch(_CheckFunction): PATCH_COMMENT = re.compile(r"^#\s*(\S+\.patch)\s*$") IGNORE_CVES = re.compile(r"^[A-Z0-9_]+_IGNORE_CVES\s*\+?=") - CVE_TAG_IN_PATCH = re.compile(r"^CVE: *CVE-\d+-\d+$") + CVE_TAG_IN_PATCH = re.compile(r"^CVE: *([\w-]+)$") def before(self): self.pending_patches = [] diff --git a/utils/checkpackagelib/test_lib_mk.py b/utils/checkpackagelib/test_lib_mk.py index 21effa9489..9d2950ef79 100644 --- a/utils/checkpackagelib/test_lib_mk.py +++ b/utils/checkpackagelib/test_lib_mk.py @@ -239,6 +239,17 @@ MissingCVEPatch = [ {}, 'FOO_IGNORE_CVES += CVE-2000-1234\n', []), + ('invalid syntax in patch', + {'0001-some-fix.patch': 'CVE: FOO:123'}, + '# 0001-some-fix.patch\n' + 'FOO_IGNORE_CVES += FOO:123\n', + [['{}: patch file \'0001-some-fix.patch\' is missing \'CVE:\' tag', + '# 0001-some-fix.patch\n']]), + ('patches present with other identifier', + {'0001-some-fix.patch': 'CVE: GHSA-abcd-1234-efgh'}, + '# 0001-some-fix.patch\n' + 'FOO_IGNORE_CVES += GHSA-abcd-1234-efgh\n', + []), ]