package/socat: drop optional readline dependency

socat is licensed under GPL-2.0, which is not license compatible with
readline (GPL-3.0+), so drop the optional dependency and add a comment
explaining why.

This also matches how socat is packaged in Debian, where the man page has
the following snippet added:

READLINE

  Uses GNU readline and history on stdio to allow editing and reusing input lines (example).
  Due to licensing restrictions the readline feature is disabled in Debian.  See BUGS.
  You can use STDIO instead.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
(cherry picked from commit 47def13564)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
Peter Korsgaard
2019-11-13 16:17:24 +01:00
parent 0cd23038d8
commit 6c38df5e8e

View File

@@ -29,6 +29,8 @@ endif
# automake, so we can't use the normal autoreconf logic. # automake, so we can't use the normal autoreconf logic.
SOCAT_DEPENDENCIES = host-autoconf SOCAT_DEPENDENCIES = host-autoconf
# incompatibile license (GPL-3.0+)
SOCAT_CONF_OPTS = --disable-readline
ifeq ($(BR2_PACKAGE_OPENSSL),y) ifeq ($(BR2_PACKAGE_OPENSSL),y)
SOCAT_DEPENDENCIES += openssl SOCAT_DEPENDENCIES += openssl
@@ -36,12 +38,6 @@ else
SOCAT_CONF_OPTS += --disable-openssl SOCAT_CONF_OPTS += --disable-openssl
endif endif
ifeq ($(BR2_PACKAGE_READLINE),y)
SOCAT_DEPENDENCIES += readline
else
SOCAT_CONF_OPTS += --disable-readline
endif
define SOCAT_RUN_AUTOCONF define SOCAT_RUN_AUTOCONF
(cd $(@D); $(HOST_DIR)/bin/autoconf) (cd $(@D); $(HOST_DIR)/bin/autoconf)
endef endef