From 731121fc1b0f968fc94e8b168014c35d970ac7e8 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Mon, 19 Oct 2026 21:30:41 +0200 Subject: [PATCH] utils/genrandconfig: add missing newline The line: configlines.remove('BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y') would fail with: Traceback (most recent call last): File "/home/thomas/projets/buildroot/./utils/genrandconfig", line 650, in ret = asyncio.run(gen_config(args)) File "/usr/lib64/python3.14/asyncio/runners.py", line 205, in run return runner.run(main) ~~~~~~~~~~^^^^^^ File "/usr/lib64/python3.14/asyncio/runners.py", line 128, in run return self._loop.run_until_complete(task) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^ File "/usr/lib64/python3.14/asyncio/base_events.py", line 720, in run_until_complete return future.result() ~~~~~~~~~~~~~^^ File "/home/thomas/projets/buildroot/./utils/genrandconfig", line 556, in gen_config if await fixup_config(sysinfo, configfile): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/thomas/projets/buildroot/./utils/genrandconfig", line 255, in fixup_config configlines.remove('BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y') ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ValueError: list.remove(x): x not in list because all configlines end with a newline, so this needs to be fixed to: configlines.remove('BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y\n') Fixes: b07d21ab984d10cbabeb186fbd47d446e027c03b ("utils/genrandconfig: handle BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y") Signed-off-by: Thomas Petazzoni Signed-off-by: Julien Olivain --- utils/genrandconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/genrandconfig b/utils/genrandconfig index 8437d6342d..597602f257 100755 --- a/utils/genrandconfig +++ b/utils/genrandconfig @@ -252,7 +252,7 @@ async def fixup_config(sysinfo, configfile): if 'BR2_LINUX_KERNEL=y\n' in configlines and \ 'BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y\n' in configlines: - configlines.remove('BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y') + configlines.remove('BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y\n') if 'BR2_PACKAGE_LINUX_BACKPORTS=y\n' in configlines and \ 'BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG=y\n' in configlines and \