From 824c660c7540bdfd969dbb260c094bdc0508e2fa Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Wed, 5 Feb 2025 11:19:27 +0100 Subject: [PATCH] support/testing/tests/package/test_python_waitress: rework assertion Like Yann E. Morin did for support/testing/tests/package/test_python_django.py, adjust the logic to avoid the weird "self.assertTrue(False, ...)" construct, and instead test exit_code after the loop. Signed-off-by: Thomas Petazzoni --- support/testing/tests/package/test_python_waitress.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/support/testing/tests/package/test_python_waitress.py b/support/testing/tests/package/test_python_waitress.py index 46f04109c0..8024aaacfd 100644 --- a/support/testing/tests/package/test_python_waitress.py +++ b/support/testing/tests/package/test_python_waitress.py @@ -30,5 +30,4 @@ class TestPythonWaitress(TestPythonPackageBase): if exit_code == 0: self.assertEqual(output[0], 'Hello, World!') break - else: - self.assertTrue(False, "Timeout while waiting for waitress server") + self.assertEqual(exit_code, 0, "Timeout while waiting for django server")