From 87b8428c4017b220afe950aae3a673870698d986 Mon Sep 17 00:00:00 2001 From: Sen Hastings Date: Wed, 23 Oct 2024 02:52:52 -0700 Subject: [PATCH] support/scripts/pkg-stats: add unsure_cves to cve_total calculation When I initially made the CVE cells collapsible, I neglected to count the unsure CVEs. This patch adds unsure CVEs to the cell collapsing calcualation to ensure that cells with lots of unsure CVEs actually get collapsed. This patch also removes the "+ 1" from the cve_total calculation, which fixes the cve_total being off-by-one. I'm not sure *why* I did that in the first place. demo: https://sen-h.codeberg.page/pkg-stats-demos/@pages/add-unsure_cves-to-cve_total-calc.html Signed-off-by: Sen Hastings Signed-off-by: Thomas Petazzoni --- support/scripts/pkg-stats | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats index f143af6446..33c21e77b4 100755 --- a/support/scripts/pkg-stats +++ b/support/scripts/pkg-stats @@ -1043,7 +1043,8 @@ def dump_html_pkg(f, pkg): data_field_id = f'cves__{pkg_css_class}' div_class = ["centered cves data"] div_class.append(f'_{pkg_css_class}') - if len(pkg.cves) > 10: + cve_total = len(pkg.cves) + len(pkg.unsure_cves) + if cve_total > 10: div_class.append("collapse") if pkg.is_status_ok("cve"): div_class.append("cve-ok") @@ -1054,8 +1055,7 @@ def dump_html_pkg(f, pkg): else: div_class.append("cve-unknown") f.write(f'
\n') - if len(pkg.cves) > 10: - cve_total = len(pkg.cves) + 1 + if cve_total > 10: f.write(f'
see all ({cve_total}) ▾
\n') if pkg.is_status_error("cve"):