From a204f52222e3e4fda1f1db6c2254c99c9e063c29 Mon Sep 17 00:00:00 2001 From: Bernd Kuhls Date: Fri, 24 Jul 2026 18:48:28 +0200 Subject: [PATCH] package/taglib: needs gcc >= 7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes a build error caught by the Gitlab pipelines: /builds/bkuhls/buildroot/br-test-pkg/bootlin-aarch64-glibc-old/build/taglib-2.3/taglib/mpeg/mpegfile.cpp:113:10: error: expected primary-expression before ‘const’ if(const Header header(&file, headerOffset + i, true); header.isValid()) { which was introduced by code format changes in upstream commit https://github.com/taglib/taglib/commit/dfe2aa52532fc9f73a67499dd17fb527a856a22f which was first released with taglib 2.0, added to buildroot with commit 9cd3464afa13fd0190fb3e94fd850cc8063cf297. This "init-statement" C++17 language feature was described in proposal P0305R1, and according to https://en.cppreference.com/cpp/compiler_support/17, this feature was only supported in gcc starting from gcc 7.x. Signed-off-by: Bernd Kuhls Signed-off-by: Thomas Petazzoni (cherry picked from commit d16e4939ca7ca8e0e464230e0b2edbea843e3e3e) Signed-off-by: Raphaël Mélotte --- package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++-- package/taglib/Config.in | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in index 6a738faa00..c4eb4efb65 100644 --- a/package/gstreamer1/gst1-plugins-good/Config.in +++ b/package/gstreamer1/gst1-plugins-good/Config.in @@ -403,13 +403,15 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SPEEX config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TAGLIB bool "taglib" depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17 depends on BR2_USE_WCHAR select BR2_PACKAGE_TAGLIB help Taglib tagging plugin library -comment "taglib needs a toolchain w/ C++, wchar" - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR +comment "taglib needs a toolchain w/ C++, wchar, gcc >= 7" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ + || !BR2_TOOLCHAIN_GCC_AT_LEAST_7 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TWOLAME bool "twolame" diff --git a/package/taglib/Config.in b/package/taglib/Config.in index 5b641a9653..9a43c82a5e 100644 --- a/package/taglib/Config.in +++ b/package/taglib/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_TAGLIB bool "taglib" depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17 depends on BR2_USE_WCHAR select BR2_PACKAGE_UTFCPP help @@ -12,5 +13,6 @@ config BR2_PACKAGE_TAGLIB http://taglib.org/ -comment "taglib needs a toolchain w/ C++, wchar" - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR +comment "taglib needs a toolchain w/ C++, wchar, gcc >= 7" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ + || !BR2_TOOLCHAIN_GCC_AT_LEAST_7