From a4469e87672f6b653ffa1a9e61352be4132eeeaf Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Sat, 4 Jan 2025 22:38:41 +0100 Subject: [PATCH] package/cryptodev-linux: ensure _LINUX_CONFIG_FIXUPS has an effect The variable _LINUX_CONFIG_FIXUPS defined in the cryptodev-linux... has no effect. Indeed, the variable is only named CRYPTODEV_LINUX_CONFIG_FIXUPS. But the variable name being _LINUX_CONFIG_FIXUPS and the package name being CRYPTODEV_LINUX, the correct variable name is CRYPTODEV_LINUX_LINUX_CONFIG_FIXUPS. Prior to this commit, a configuration with cryptodev-linux enabled would result in: $ make VARS=PACKAGES_LINUX_CONFIG_FIXUPS printvars $ Aka, empty, while PACKAGES_LINUX_CONFIG_FIXUPS collects in package/pkg-generic.mk the value of the _LINUX_CONFIG_FIXUPS variables from all enabled packages. With this patch applied: $ make VARS=PACKAGES_LINUX_CONFIG_FIXUPS printvars PACKAGES_LINUX_CONFIG_FIXUPS= @if ! grep -q '^CONFIG_CRYPTO=[my]' /; then /usr/bin/sed -i -e '/^\(# \)\?CONFIG_CRYPTO\>/d' / && echo 'CONFIG_CRYPTO=y' >> /; fi @if ! grep -q '^CONFIG_CRYPTO_USER_API_AEAD=[my]' /; then /usr/bin/sed -i -e '/^\(# \)\?CONFIG_CRYPTO_USER_API_AEAD\>/d' / && echo 'CONFIG_CRYPTO_USER_API_AEAD=y' >> /; fi $ As one would expect. Fixes: 4b12336d1fad12fbb82b4d9144e6cb5636a12256 ("package/cryptodev-linux: needs CONFIG_CRYPTO_USER_API_AEAD") Signed-off-by: Thomas Petazzoni Signed-off-by: Julien Olivain (cherry picked from commit 9114d48b313744fd163e4eeea0f5b0407568e771) Signed-off-by: Peter Korsgaard --- package/cryptodev-linux/cryptodev-linux.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/cryptodev-linux/cryptodev-linux.mk b/package/cryptodev-linux/cryptodev-linux.mk index 580ea89520..550a248a27 100644 --- a/package/cryptodev-linux/cryptodev-linux.mk +++ b/package/cryptodev-linux/cryptodev-linux.mk @@ -21,7 +21,7 @@ define CRYPTODEV_LINUX_INSTALL_STAGING_CMDS $(STAGING_DIR)/usr/include/crypto/cryptodev.h endef -define CRYPTODEV_LINUX_CONFIG_FIXUPS +define CRYPTODEV_LINUX_LINUX_CONFIG_FIXUPS $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO) $(call KCONFIG_ENABLE_OPT,CONFIG_CRYPTO_USER_API_AEAD) endef