From b42d59e25f59ac01a21beb5eed59d26d3f7288ef Mon Sep 17 00:00:00 2001
From: Peter Seiderer <ps.report@gmx.net>
Date: Sun, 4 Oct 2026 17:21:04 +0200
Subject: [PATCH] package/dhcpcd: fix check-package warnings in S41dhcpcd
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Update S41dhcpcd:

- use plain "dhcpcd" for DAEMON (instead of "/sbin/dhcpcd"), adjust
  PIDFILE accordingly and while at it use quotation marks for variable
  definitions
- fix indent (tabs vs. spaces)

Fixes:

  $ ./utils/check-package package/dhcpcd/*
  package/dhcpcd/S41dhcpcd:6: Do not include path in DAEMON (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:8: Incorrect PIDFILE value  (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:13: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:17: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:21: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:25: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)
  package/dhcpcd/S41dhcpcd:30: should be indented with tabs (https://nightly.buildroot.org/#adding-packages-start-script)

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
(cherry picked from commit 42c3ecb29356fef0df652f8e4b231d225a3e5162)
Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
---
 .checkpackageignore      |  1 -
 package/dhcpcd/S41dhcpcd | 46 ++++++++++++++++++++--------------------
 2 files changed, 23 insertions(+), 24 deletions(-)

diff --git a/.checkpackageignore b/.checkpackageignore
index b6bbda1728..298cd65838 100644
--- a/.checkpackageignore
+++ b/.checkpackageignore
@@ -274,7 +274,6 @@ package/dcron/S90dcron lib_sysv.Variables
 package/dhcp/S80dhcp-relay Shellcheck lib_sysv.Variables
 package/dhcp/S80dhcp-server Shellcheck lib_sysv.Variables
 package/dhcp/dhclient-script Shellcheck lib_shellscript.TrailingSpace
-package/dhcpcd/S41dhcpcd lib_sysv.Indent lib_sysv.Variables
 package/dmalloc/0001-configure-fix-build-on-mips.patch lib_patch.Upstream
 package/dmalloc/0003-configure-allow-overriding-some-tests.patch lib_patch.Upstream
 package/dmalloc/0004-Makefile-use-the-configure-detected-or-user-supplied.patch lib_patch.Upstream
diff --git a/package/dhcpcd/S41dhcpcd b/package/dhcpcd/S41dhcpcd
index 55794f4075..e52e935da2 100644
--- a/package/dhcpcd/S41dhcpcd
+++ b/package/dhcpcd/S41dhcpcd
@@ -3,31 +3,31 @@
 # Start/stop dhcpcd
 #
 
-DAEMON=/sbin/dhcpcd
-CONFIG=/etc/dhcpcd.conf
-PIDFILE=/var/run/dhcpcd/pid
+DAEMON="dhcpcd"
+CONFIG="/etc/dhcpcd.conf"
+PIDFILE="/var/run/$DAEMON/pid"
 
 [ -f $CONFIG ] || exit 0
 
 case "$1" in
-  start)
-	echo "Starting dhcpcd..."
-	start-stop-daemon -S -x "$DAEMON" -p "$PIDFILE" -- -f "$CONFIG"
-	;;
-  stop)
-	echo "Stopping dhcpcd..."
-	start-stop-daemon -K -x "$DAEMON" -p "$PIDFILE" -o
-	;;
-  reload|force-reload)
-	echo "Reloading dhcpcd configuration..."
-	"$DAEMON" -s reload
-	;;
-  restart)
-	"$0" stop
-	sleep 1 # Prevent race condition: ensure dhcpcd stops before start.
-	"$0" start
-	;;
-  *)
-	echo "Usage: $0 {start|stop|restart|reload|force-reload}"
-	exit 1
+	start)
+		echo "Starting dhcpcd..."
+		start-stop-daemon -S -x "/sbin/$DAEMON" -p "$PIDFILE" -- -f "$CONFIG"
+		;;
+	stop)
+		echo "Stopping dhcpcd..."
+		start-stop-daemon -K -x "/sbin/$DAEMON" -p "$PIDFILE" -o
+		;;
+	reload|force-reload)
+		echo "Reloading dhcpcd configuration..."
+		"$DAEMON" -s reload
+		;;
+	restart)
+		"$0" stop
+		sleep 1 # Prevent race condition: ensure dhcpcd stops before start.
+		"$0" start
+		;;
+	*)
+		echo "Usage: $0 {start|stop|restart|reload|force-reload}"
+		exit 1
 esac