From ccad393abf2abb386d3031ee4a28f8317ba9a891 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Sat, 12 Sep 2026 23:00:46 +0200 Subject: [PATCH] package/mpd: enable smb support on uClibc samba4 is available on !musl, but samba support in mpd is available only with glibc. Turns out that samba support in mpd builds just fine with uClibc-ng, and that samba4 no longer needs native RPC support: it can use libtirpc when needed (it's handled in the samba4 package itself). Tested with the following defconfig: BR2_aarch64=y BR2_TOOLCHAIN_EXTERNAL=y BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_AARCH64_UCLIBC_BLEEDING_EDGE=y BR2_PACKAGE_MPD=y BR2_PACKAGE_MPD_LIBSMBCLIENT=y Signed-off-by: Thomas Petazzoni Signed-off-by: Julien Olivain --- package/mpd/Config.in | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/package/mpd/Config.in b/package/mpd/Config.in index 1b6815e904..831cbe933d 100644 --- a/package/mpd/Config.in +++ b/package/mpd/Config.in @@ -226,16 +226,17 @@ config BR2_PACKAGE_MPD_LIBNFS comment "nfs support needs a toolchain w/ threads support" depends on !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC) -comment "samba support needs a glibc toolchain w/ dynamic library, RPC" - depends on !BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS || \ - !BR2_TOOLCHAIN_HAS_NATIVE_RPC +comment "samba support needs a glibc or uclibc toolchain w/ dynamic library, NPTL" + depends on BR2_TOOLCHAIN_HAS_SYNC_4 + depends on BR2_TOOLCHAIN_USES_MUSL || BR2_STATIC_LIBS || \ + !BR2_TOOLCHAIN_HAS_THREADS_NPTL config BR2_PACKAGE_MPD_LIBSMBCLIENT bool "samba" - depends on BR2_TOOLCHAIN_USES_GLIBC - depends on !BR2_STATIC_LIBS - depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC - depends on BR2_TOOLCHAIN_HAS_SYNC_4 + depends on !BR2_TOOLCHAIN_USES_MUSL # samba4 + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # samba4 + depends on !BR2_STATIC_LIBS # samba4 + depends on BR2_TOOLCHAIN_HAS_SYNC_4 # samba4 select BR2_PACKAGE_SAMBA4 help Enable Samba support.