From d582bf978fe6a9002a7950c6fd7c33fe1e0d5df5 Mon Sep 17 00:00:00 2001 From: David Johnson Date: Mon, 1 May 2023 16:36:47 -0400 Subject: [PATCH] package/netsnmp: add a snmp user so snmpd doesn't run as root Signed-off-by: David Johnson Signed-off-by: Thomas Petazzoni --- package/netsnmp/S59snmpd | 2 +- package/netsnmp/netsnmp.mk | 4 ++++ package/netsnmp/snmpd.service | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd index 96ed8237ac..aece896670 100644 --- a/package/netsnmp/S59snmpd +++ b/package/netsnmp/S59snmpd @@ -17,7 +17,7 @@ export PATH=/sbin:/usr/sbin:/bin:/usr/bin # Defaults export MIBDIRS=/usr/share/snmp/mibs SNMPDRUN=yes -SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid 127.0.0.1' +SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid -u snmp -g snmp 127.0.0.1' TRAPDRUN=no TRAPDOPTS='-Lsd -p /var/run/snmptrapd.pid' diff --git a/package/netsnmp/netsnmp.mk b/package/netsnmp/netsnmp.mk index 0218e65b91..c7df49f947 100644 --- a/package/netsnmp/netsnmp.mk +++ b/package/netsnmp/netsnmp.mk @@ -41,6 +41,10 @@ NETSNMP_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) LIB_LDCONFIG_CMD=true instal NETSNMP_MAKE = $(MAKE1) NETSNMP_CONFIG_SCRIPTS = net-snmp-config +define NETSNMP_USERS + snmp -1 snmp -1 * - - - snmpd user +endef + ifeq ($(BR2_INIT_SYSTEMD),y) NETSNMP_CONF_OPTS += --with-systemd else diff --git a/package/netsnmp/snmpd.service b/package/netsnmp/snmpd.service index 2a1e6e9715..6647b10c32 100644 --- a/package/netsnmp/snmpd.service +++ b/package/netsnmp/snmpd.service @@ -6,7 +6,7 @@ ConditionPathExists=/etc/snmp/snmpd.conf [Service] Type=simple Environment=MIBDIRS=/usr/share/snmp/mibs -Environment=SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid 127.0.0.1' +Environment=SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid -u snmp -g snmp 127.0.0.1' EnvironmentFile=-/etc/default/snmpd PassEnvironment=MIBDIRS ExecStart=/usr/sbin/snmpd -f $SNMPDOPTS