From e3a1340e2db759dfaec680ba3727a15e95ab3755 Mon Sep 17 00:00:00 2001 From: Bernd Kuhls Date: Mon, 29 Dec 2025 18:59:09 +0100 Subject: [PATCH] package/libnids: remove package Analysis of https://github.com/MITRECND/libnids: "This repository was archived by the owner on May 20, 2025." last commit: Dec 2020 last bug report: Jul 2024 last patch sent upstream: Jan 2024 The package is broken with gcc 15.x and no other package depends on it. Fixes: https://autobuild.buildroot.net/results/f22/f22c8954894ab9ca57df07571726140c5bf3499a/ Signed-off-by: Bernd Kuhls Cc: Guillaume William Brs Signed-off-by: Thomas Petazzoni --- .checkpackageignore | 1 - Config.in.legacy | 6 +++ DEVELOPERS | 1 - package/Config.in | 1 - .../libnids/0001-libpcap-use-pkg-config.patch | 48 ------------------- package/libnids/Config.in | 14 ------ package/libnids/libnids.hash | 3 -- package/libnids/libnids.mk | 43 ----------------- 8 files changed, 6 insertions(+), 111 deletions(-) delete mode 100644 package/libnids/0001-libpcap-use-pkg-config.patch delete mode 100644 package/libnids/Config.in delete mode 100644 package/libnids/libnids.hash delete mode 100644 package/libnids/libnids.mk diff --git a/.checkpackageignore b/.checkpackageignore index 1e255f80e1..0d0bbcaf2d 100644 --- a/.checkpackageignore +++ b/.checkpackageignore @@ -574,7 +574,6 @@ package/libmpeg2/0003-fix-arm-detection.patch lib_patch.Upstream package/libmpeg2/0004-fix-sparc.patch lib_patch.Upstream package/libnetfilter_conntrack/0001-conntrack-fix-build-with-kernel-5-15-and-musl.patch lib_patch.Upstream package/libnfc/0001-autotools-make-example-build-optional.patch lib_patch.Upstream -package/libnids/0001-libpcap-use-pkg-config.patch lib_patch.Upstream package/libnss/0001-Bug-1801182-Allow-overriding-OS_ARCH-OS_TEST-and-OS_.patch lib_patch.Upstream package/libodb-mysql/0001-fix-syntax-issue-while-checking-ldflags.patch lib_patch.Upstream package/libodb-mysql/0002-mariadb-FTBFS-fix.patch lib_patch.Upstream diff --git a/Config.in.legacy b/Config.in.legacy index 329336fa2a..4ed11ff095 100644 --- a/Config.in.legacy +++ b/Config.in.legacy @@ -146,6 +146,12 @@ endif comment "Legacy options removed in 2026.02" +config BR2_PACKAGE_LIBNIDS + bool "libnids has been removed" + select BR2_LEGACY + help + libnids is unmaintained and has been removed + config BR2_TARGET_S500_BOOTLOADER bool "s500-bootloader" select BR2_LEGACY diff --git a/DEVELOPERS b/DEVELOPERS index ffc14ced6f..b9750d25b6 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -1378,7 +1378,6 @@ N: Guillaume Chaye F: package/sane-airscan/ N: Guillaume William Brs -F: package/libnids/ F: package/libxcrypt/ F: package/liquid-dsp/ F: package/mbw/ diff --git a/package/Config.in b/package/Config.in index b2e8229d5d..3059b144e2 100644 --- a/package/Config.in +++ b/package/Config.in @@ -2075,7 +2075,6 @@ menu "Networking" source "package/libnfnetlink/Config.in" source "package/libnftnl/Config.in" source "package/libnice/Config.in" - source "package/libnids/Config.in" source "package/libnl/Config.in" source "package/libnpupnp/Config.in" source "package/liboping/Config.in" diff --git a/package/libnids/0001-libpcap-use-pkg-config.patch b/package/libnids/0001-libpcap-use-pkg-config.patch deleted file mode 100644 index 8f8df478d1..0000000000 --- a/package/libnids/0001-libpcap-use-pkg-config.patch +++ /dev/null @@ -1,48 +0,0 @@ -configure.in: use pkg-config for libpcap detection - -The detection of libpcap was based in ${prefix}, which doesn't make -sense in a cross-compilation context and can cause host leakage into -the target build. - -So instead, let's use pkg-config to detect libpcap, since it is anyway -already use in this configure.in to detect libglib. - -Signed-off-by: Thomas Petazzoni - -Index: b/configure.in -=================================================================== ---- a/configure.in -+++ b/configure.in -@@ -75,25 +75,13 @@ - fi - ;; - esac ], --[ if test -f ${prefix}/include/pcap.h; then -- PCAP_CFLAGS="-I${prefix}/include" -- PCAPLIB="-L${exec_prefix}/lib -lpcap" -- elif test -f /usr/include/pcap/pcap.h; then -- PCAP_CFLAGS="-I/usr/include/pcap" -- PCAPLIB="-lpcap" -- else -- TMP=$LIBS -- LIBS="-lpcap $LIBS" -- AC_TRY_LINK([#include ], pcap_open_offline("",""), -- LIBPCAP_FOUND=1,LIBPCAP_FOUND=0) -- LIBS=$TMP -- if test $LIBPCAP_FOUND = 1 ; then -- PCAPLIB="-lpcap" -- else -- AC_ERROR(libpcap not found) -- fi -- fi -- AC_MSG_RESULT(yes) ] -+[ -+ PKG_PROG_PKG_CONFIG -+ PKG_CHECK_MODULES(LIBPCAP, libpcap) -+ AC_MSG_RESULT(yes) -+ PCAP_CFLAGS=${LIBPCAP_CFLAGS} -+ PCAPLIB=${LIBPCAP_LIBS} -+] - ) - AC_SUBST(PCAP_CFLAGS) - AC_SUBST(PCAPLIB) diff --git a/package/libnids/Config.in b/package/libnids/Config.in deleted file mode 100644 index 30528f4d07..0000000000 --- a/package/libnids/Config.in +++ /dev/null @@ -1,14 +0,0 @@ -config BR2_PACKAGE_LIBNIDS - bool "libnids" - select BR2_PACKAGE_LIBPCAP - help - Libnids is an implementation of an E-component of Network - Intrusion Detection System. - - libnids watches all local network traffic, and provides - convenient information on them to perform further analysis. - - Libnids offers IP defragmentation, TCP stream assembly, TCP - port scan detection. - - http://libnids.sourceforge.net/ diff --git a/package/libnids/libnids.hash b/package/libnids/libnids.hash deleted file mode 100644 index e51dbf151c..0000000000 --- a/package/libnids/libnids.hash +++ /dev/null @@ -1,3 +0,0 @@ -# Locally calculated -sha256 3f3e9f99a83cd37bc74af83d415c5e3a7505f5b190dfaf456b0849e0054f6733 libnids-1.26.tar.gz -sha256 91df39d1816bfb17a4dda2d3d2c83b1f6f2d38d53e53e41e8f97ad5ac46a0cad COPYING diff --git a/package/libnids/libnids.mk b/package/libnids/libnids.mk deleted file mode 100644 index 712630bac8..0000000000 --- a/package/libnids/libnids.mk +++ /dev/null @@ -1,43 +0,0 @@ -################################################################################ -# -# libnids -# -################################################################################ - -LIBNIDS_VERSION = 1.26 -LIBNIDS_SITE = $(call github,MITRECND,libnids,$(LIBNIDS_VERSION)) -LIBNIDS_LICENSE = GPL-2.0 -LIBNIDS_LICENSE_FILES = COPYING -LIBNIDS_CPE_ID_VALID = YES -LIBNIDS_INSTALL_STAGING = YES -LIBNIDS_DEPENDENCIES = host-pkgconf libpcap -LIBNIDS_AUTORECONF = YES - -# disable libnet if not available -# Tests in configure.in expect --with-libnet=$build_dir -# not an installation patch like in our context. -# We use with-libnet=yes to skip the unusual paths tests. -# But 'LNETLIB' gets left out, so we need to define it ourselves. -ifeq ($(BR2_PACKAGE_LIBNET),y) -LIBNIDS_DEPENDENCIES += libnet -LIBNIDS_CONF_OPTS += --enable-libnet --with-libnet=yes LNETLIB=-lnet -else -LIBNIDS_CONF_OPTS += --disable-libnet -endif - -# disable libglib2 if not available -# The test in configure.in is flawed: passing --enable-libglib would also -# disable it. Only when neither is passed will the autodetection test be -# executed. -ifeq ($(BR2_PACKAGE_LIBGLIB2),y) -LIBNIDS_DEPENDENCIES += libglib2 -else -LIBNIDS_CONF_OPTS += --disable-libglib -endif - -# hand-written Makefile.in, not using automake, needs a custom -# variable for the installation path. -LIBNIDS_INSTALL_STAGING_OPTS = install_prefix=$(STAGING_DIR) install -LIBNIDS_INSTALL_TARGET_OPTS = install_prefix=$(TARGET_DIR) install - -$(eval $(autotools-package))