From f38453f00e9f7852ad4132d2aff5a9f6f2fab684 Mon Sep 17 00:00:00 2001 From: Peter Seiderer Date: Tue, 5 Aug 2025 19:16:02 +0200 Subject: [PATCH] package/iwd: suppress S40iwd shellcheck warnings - suppress S40iwd shellcheck warnings: In package/iwd/S40iwd line 8: [ -r "/etc/default/$DAEMON" ] && . "/etc/default/$DAEMON" ^--------------------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location. In package/iwd/S40iwd line 15: -- $IWD_ARGS ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. - remove package/iwd/S40iwd from .checkpackageignore Signed-off-by: Peter Seiderer Signed-off-by: Thomas Petazzoni --- .checkpackageignore | 1 - package/iwd/S40iwd | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.checkpackageignore b/.checkpackageignore index 042a96a48f..99a864fd3f 100644 --- a/.checkpackageignore +++ b/.checkpackageignore @@ -487,7 +487,6 @@ package/irqbalance/S13irqbalance Shellcheck lib_sysv.Indent lib_sysv.Variables package/irrlicht/0001-override-CPPFLAGS-CXXFLAGS-and-CFLAGS-in-Makefile.patch lib_patch.Upstream package/irrlicht/0002-makefile-override-LDFLAGS-and-remove-obsolete-X11R6-.patch lib_patch.Upstream package/iucode-tool/S00iucode-tool lib_sysv.Variables -package/iwd/S40iwd Shellcheck package/janus-gateway/0001-disable-ssp.patch lib_patch.Upstream package/kexec-lite/0001-clean-restart.patch lib_patch.Upstream package/keyutils/0001-fix-install-rule.patch lib_patch.Upstream diff --git a/package/iwd/S40iwd b/package/iwd/S40iwd index de5a1efb6f..1a2d0e9780 100644 --- a/package/iwd/S40iwd +++ b/package/iwd/S40iwd @@ -5,11 +5,13 @@ PIDFILE="/var/run/$DAEMON.pid" IWD_ARGS="" +# shellcheck source=/dev/null [ -r "/etc/default/$DAEMON" ] && . "/etc/default/$DAEMON" start() { printf 'Starting %s: ' "$DAEMON" mkdir -p /tmp/iwd/hotspot + # shellcheck disable=SC2086 # we need the word splitting start-stop-daemon --start --background --make-pidfile \ --pidfile "$PIDFILE" --exec "/usr/libexec/$DAEMON" \ -- $IWD_ARGS