From f6fe892141cd4c8b6dd934df92eb1fe7d9469e0c Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Sun, 29 Dec 2024 21:26:44 +0100 Subject: [PATCH] package/procps-ng: add wchar dependency Since procps-ng was bumped from 3.3.17 to 4.0.4 in commit d79f40dbbe98983bc657d4c82d46b38b8283351b ("package/procps-ng: security bump to version 4.0.4"), the build has been failing on !wchar configurations with: src/ps/output.c:68:10: fatal error: wctype.h: No such file or directory 68 | #include | ^~~~~~~~~~ compilation terminated. The problematic code has been added by upstream commit https://gitlab.com/procps-ng/procps/-/commit/605ea4a8f7460920b6de9e432757bd13f80f0dba, which landed in upstream release v4.0.0. To solve this, we simply add a BR2_USE_WCHAR dependency, and update the comment related to this dependency on the only reverse dependency of procps-ng. Fixes: http://autobuild.buildroot.net/results/afc035e866bec6f2c14f9d52fa74a9c1897706de/ Signed-off-by: Thomas Petazzoni Signed-off-by: Julien Olivain --- package/igt-gpu-tools/Config.in | 2 +- package/procps-ng/Config.in | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/package/igt-gpu-tools/Config.in b/package/igt-gpu-tools/Config.in index 809c8e28ac..08fc34e917 100644 --- a/package/igt-gpu-tools/Config.in +++ b/package/igt-gpu-tools/Config.in @@ -5,7 +5,7 @@ config BR2_PACKAGE_IGT_GPU_TOOLS depends on !BR2_STATIC_LIBS depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_PACKAGE_HAS_UDEV - depends on BR2_USE_WCHAR # elfutils + depends on BR2_USE_WCHAR # elfutils, procps-ng depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_11 # linux/dma-buf.h select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # procps-ng select BR2_PACKAGE_CAIRO diff --git a/package/procps-ng/Config.in b/package/procps-ng/Config.in index 7af0e97fb4..2b97096f00 100644 --- a/package/procps-ng/Config.in +++ b/package/procps-ng/Config.in @@ -1,7 +1,13 @@ +comment "procps-ng needs a toolchain w/ wchar" + depends on BR2_USE_MMU + depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS + depends on !BR2_USE_WCHAR + config BR2_PACKAGE_PROCPS_NG bool "procps-ng" depends on BR2_USE_MMU # fork() depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS + depends on BR2_USE_WCHAR select BR2_PACKAGE_NCURSES help Standard informational utilities and process-handling tools.