mirror of
https://gitlab.com/buildroot.org/buildroot.git
synced 2026-09-19 16:40:46 -09:00
c72be5dd2f
riscv32 is (surprise!) a 32-bit architecture. But it has been Y2038-safe
from its inception. As such, there are no legacy binaries that may use
the 32-bit time syscalls, and thus they are not available on riscv32.
Code that directly calls to the syscalls without using the C libraries
wrappers thus need to handle this case by themselves. That's what
upstream tried to do with:
5b5e2985f3
We initially carried that patch with 2bb26c1a1d (package/libopenssl:
fix build on riscv32).
However, as Arnd Bergmann puts it [0]:
The patch looks wrong to me: __NR_io_pgetevents_time64 must be used
whenever time_t is 64-bit wide on a 32-bit architecture, while
__NR_io_getevents/__NR_io_pgetevents must be used when time_t is the
same width as 'long'.
Checking whether __NR_io_getevents is defined is wrong for all
architectures other than riscv
And Arnd agrees that patch should be reverted [1] [2] (there are further
comments in that stream, that are worth reading).
As such, we've reverted 2bb26c1a1d with 6cfb4ad7f7.
This means we have no working solution to enable openssl on riscv32 for
now. So, rather than fail the build, or backport a dysfunctional patch,
let's just forbid openssl on riscv32.
Drop the default from the choice selection; it was anyway superfluous:
the default of a choice, if left unspecified, is the first entry of the
choice. Also, having a default means we'd have to also propagate the
dependencies of the defaulted-to symbol, which is yet a little bit more
maintenance. Since the chances we get a third implementation of openssl
are pretty slim (very, very slim), reasoning about what is the default
is still very easy.
When propagating dependencies to tpm2-tss' users, we've tried to keep
the architecture dependency toward the top when possible, and otherwise
we've added it together with existing arch dependencies (MMU).
While at it, drop a useless redundant comment in ibm-sw-tpm2: if we
select FORCE_LIBOPENSSL, it is obvious that's because libressl is not
supported... Besides none of the other users of FORCE_LIBOPENSSL have
such a comment.
Fixes:
http://autobuild.buildroot.org/results/eb9/eb9a64d4ffae8569b5225083f282cf87ffa7c681/
...
http://autobuild.buildroot.org/results/07e/07e413b24ba8adc9558c80267ce16dda339bf032/
[0] 5b5e2985f3 (commitcomment-44782859)
[1] 5b5e2985f3 (commitcomment-47826509)
[2] 5b5e2985f3 (commitcomment-47830530)
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Peter Korsgaard <peter@korsgaard.com>
Cc: Matthew Weber <matthew.weber@rockwellcollins.com>
Cc: Mark Corbin <mark@dibsco.co.uk>
33 lines
1.2 KiB
Plaintext
33 lines
1.2 KiB
Plaintext
config BR2_PACKAGE_SOFTETHER
|
|
bool "softether"
|
|
depends on BR2_TOOLCHAIN_HAS_THREADS
|
|
depends on BR2_USE_MMU # fork()
|
|
depends on BR2_USE_WCHAR
|
|
depends on BR2_PACKAGE_LIBOPENSSL_ARCH_SUPPORTS
|
|
select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
|
|
select BR2_PACKAGE_OPENSSL
|
|
select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
|
|
select BR2_PACKAGE_READLINE
|
|
help
|
|
The SoftEther Server is a fully integrated implementation of
|
|
the SSTP, L2TP, L2TPv3, OpenVPN, and IPSec virtual private
|
|
networking protocols on Linux and several other
|
|
platforms. It is generally compatible with other
|
|
implementations by Apple, Cisco, Juniper, Microsoft, et al.
|
|
|
|
Convenient Layer-2 and Layer-3 bridging capabilities can
|
|
connect several branch offices into a single broadcast or
|
|
routing domain, even behind a NAT or without a static IPv4
|
|
address.
|
|
|
|
In addition to supporting most VPN protocols, the SoftEther
|
|
Client can penetrate hardened firewalls and captured
|
|
gateways through HTTPS, DNS, and ICMP exfiltration.
|
|
|
|
http://www.softether.org
|
|
|
|
comment "softether needs a toolchain w/ wchar, threads"
|
|
depends on BR2_USE_MMU
|
|
depends on BR2_PACKAGE_LIBOPENSSL_ARCH_SUPPORTS
|
|
depends on !(BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS)
|