mirror of
https://gitlab.com/buildroot.org/buildroot.git
synced 2026-09-26 03:50:44 -09:00
3f14fed1de
When $(TOPDIR)/dl is a symlink, checking out git submodules can fail,
as reported by Michael in #11086.
To reproduce a similarly-related mis-behaviour:
$ mkdir -p foo/bar foo/buz
$ cd foo/bar
$ ln -s ../buz meh
$ cd meh
$ cd ../../foo
The last command should not succeed, because, relative to meh, there is
no ../../foo directory; we would expect it to be ../../../foo, instead.
But since meh is a symlink to a directory, then a relative path from that
symlink is interpreted as relative to the derefrenced directory, i.e.
from buz in this case.
But where this gets even weirder, is that, if the last command is
replaced by:
$ cd ../../../foo
then it still works, too.
And that is the root of Michael's issue: the dl directory in Buildroot's
TOPDIR is a symlink to a similarly-named directory one directory higher,
which then confuses relative paths, which gets especially and noticeably
bad for git submodules.
Avoid this strangeness, and just use so-called "physical" path, i.e. a
path where all symlinks to directories have been dereferenced.
Fixes: #11086
Reported-by: Michael Nosthoff <posted@heine.so>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Michael Nosthoff <posted@heine.so>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
(cherry picked from commit 632e164a19)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
213 lines
6.5 KiB
Makefile
213 lines
6.5 KiB
Makefile
################################################################################
|
|
#
|
|
# This file contains the download helpers for the various package
|
|
# infrastructures. It is used to handle downloads from HTTP servers,
|
|
# FTP servers, Git repositories, Subversion repositories, Mercurial
|
|
# repositories, Bazaar repositories, and SCP servers.
|
|
#
|
|
################################################################################
|
|
|
|
# Download method commands
|
|
export WGET := $(call qstrip,$(BR2_WGET))
|
|
export SVN := $(call qstrip,$(BR2_SVN))
|
|
export CVS := $(call qstrip,$(BR2_CVS))
|
|
export BZR := $(call qstrip,$(BR2_BZR))
|
|
export GIT := $(call qstrip,$(BR2_GIT))
|
|
export HG := $(call qstrip,$(BR2_HG))
|
|
export SCP := $(call qstrip,$(BR2_SCP))
|
|
SSH := $(call qstrip,$(BR2_SSH))
|
|
export LOCALFILES := $(call qstrip,$(BR2_LOCALFILES))
|
|
|
|
DL_WRAPPER = support/download/dl-wrapper
|
|
|
|
# DL_DIR may have been set already from the environment
|
|
ifeq ($(origin DL_DIR),undefined)
|
|
DL_DIR ?= $(call qstrip,$(BR2_DL_DIR))
|
|
ifeq ($(DL_DIR),)
|
|
DL_DIR := $(TOPDIR)/dl
|
|
endif
|
|
else
|
|
# Restore the BR2_DL_DIR that was overridden by the .config file
|
|
BR2_DL_DIR = $(DL_DIR)
|
|
endif
|
|
|
|
# ensure it exists and a absolute path, derefrecing symlinks
|
|
DL_DIR := $(shell mkdir -p $(DL_DIR) && cd $(DL_DIR) >/dev/null && pwd -P)
|
|
|
|
#
|
|
# URI scheme helper functions
|
|
# Example URIs:
|
|
# * http://www.example.com/dir/file
|
|
# * scp://www.example.com:dir/file (with domainseparator :)
|
|
#
|
|
# geturischeme: http
|
|
geturischeme = $(firstword $(subst ://, ,$(call qstrip,$(1))))
|
|
# stripurischeme: www.example.com/dir/file
|
|
stripurischeme = $(lastword $(subst ://, ,$(call qstrip,$(1))))
|
|
# domain: www.example.com
|
|
domain = $(firstword $(subst $(call domainseparator,$(2)), ,$(call stripurischeme,$(1))))
|
|
# notdomain: dir/file
|
|
notdomain = $(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(call stripurischeme,$(1)))
|
|
#
|
|
# default domainseparator is /, specify alternative value as first argument
|
|
domainseparator = $(if $(1),$(1),/)
|
|
|
|
# github(user,package,version): returns site of GitHub repository
|
|
github = https://github.com/$(1)/$(2)/archive/$(3)
|
|
|
|
# Expressly do not check hashes for those files
|
|
# Exported variables default to immediately expanded in some versions of
|
|
# make, but we need it to be recursively-epxanded, so explicitly assign it.
|
|
export BR_NO_CHECK_HASH_FOR =
|
|
|
|
################################################################################
|
|
# The DOWNLOAD_* helpers are in charge of getting a working copy
|
|
# of the source repository for their corresponding SCM,
|
|
# checking out the requested version / commit / tag, and create an
|
|
# archive out of it. DOWNLOAD_SCP uses scp to obtain a remote file with
|
|
# ssh authentication. DOWNLOAD_WGET is the normal wget-based download
|
|
# mechanism.
|
|
#
|
|
################################################################################
|
|
|
|
define DOWNLOAD_GIT
|
|
$(EXTRA_ENV) $(DL_WRAPPER) -b git \
|
|
-o $(DL_DIR)/$($(PKG)_SOURCE) \
|
|
$(if $($(PKG)_GIT_SUBMODULES),-r) \
|
|
-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \
|
|
$(QUIET) \
|
|
-- \
|
|
$($(PKG)_SITE) \
|
|
$($(PKG)_DL_VERSION) \
|
|
$($(PKG)_BASENAME_RAW) \
|
|
$($(PKG)_DL_OPTS)
|
|
endef
|
|
|
|
define DOWNLOAD_BZR
|
|
$(EXTRA_ENV) $(DL_WRAPPER) -b bzr \
|
|
-o $(DL_DIR)/$($(PKG)_SOURCE) \
|
|
$(QUIET) \
|
|
-- \
|
|
$($(PKG)_SITE) \
|
|
$($(PKG)_DL_VERSION) \
|
|
$($(PKG)_BASENAME_RAW) \
|
|
$($(PKG)_DL_OPTS)
|
|
endef
|
|
|
|
define DOWNLOAD_CVS
|
|
$(EXTRA_ENV) $(DL_WRAPPER) -b cvs \
|
|
-o $(DL_DIR)/$($(PKG)_SOURCE) \
|
|
$(QUIET) \
|
|
-- \
|
|
$(call stripurischeme,$(call qstrip,$($(PKG)_SITE))) \
|
|
$($(PKG)_DL_VERSION) \
|
|
$($(PKG)_RAWNAME) \
|
|
$($(PKG)_BASENAME_RAW) \
|
|
$($(PKG)_DL_OPTS)
|
|
endef
|
|
|
|
define DOWNLOAD_SVN
|
|
$(EXTRA_ENV) $(DL_WRAPPER) -b svn \
|
|
-o $(DL_DIR)/$($(PKG)_SOURCE) \
|
|
$(QUIET) \
|
|
-- \
|
|
$($(PKG)_SITE) \
|
|
$($(PKG)_DL_VERSION) \
|
|
$($(PKG)_BASENAME_RAW) \
|
|
$($(PKG)_DL_OPTS)
|
|
endef
|
|
|
|
# SCP URIs should be of the form scp://[user@]host:filepath
|
|
# Note that filepath is relative to the user's home directory, so you may want
|
|
# to prepend the path with a slash: scp://[user@]host:/absolutepath
|
|
define DOWNLOAD_SCP
|
|
$(EXTRA_ENV) $(DL_WRAPPER) -b scp \
|
|
-o $(DL_DIR)/$(2) \
|
|
-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \
|
|
$(QUIET) \
|
|
-- \
|
|
'$(call stripurischeme,$(call qstrip,$(1)))' \
|
|
$($(PKG)_DL_OPTS)
|
|
endef
|
|
|
|
define DOWNLOAD_HG
|
|
$(EXTRA_ENV) $(DL_WRAPPER) -b hg \
|
|
-o $(DL_DIR)/$($(PKG)_SOURCE) \
|
|
$(QUIET) \
|
|
-- \
|
|
$($(PKG)_SITE) \
|
|
$($(PKG)_DL_VERSION) \
|
|
$($(PKG)_BASENAME_RAW) \
|
|
$($(PKG)_DL_OPTS)
|
|
endef
|
|
|
|
define DOWNLOAD_WGET
|
|
$(EXTRA_ENV) $(DL_WRAPPER) -b wget \
|
|
-o $(DL_DIR)/$(2) \
|
|
-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \
|
|
$(QUIET) \
|
|
-- \
|
|
'$(call qstrip,$(1))' \
|
|
$($(PKG)_DL_OPTS)
|
|
endef
|
|
|
|
define DOWNLOAD_LOCALFILES
|
|
$(EXTRA_ENV) $(DL_WRAPPER) -b cp \
|
|
-o $(DL_DIR)/$(2) \
|
|
-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \
|
|
$(QUIET) \
|
|
-- \
|
|
$(call stripurischeme,$(call qstrip,$(1))) \
|
|
$($(PKG)_DL_OPTS)
|
|
endef
|
|
|
|
################################################################################
|
|
# DOWNLOAD -- Download helper. Will try to download source from:
|
|
# 1) BR2_PRIMARY_SITE if enabled
|
|
# 2) Download site, unless BR2_PRIMARY_SITE_ONLY is set
|
|
# 3) BR2_BACKUP_SITE if enabled, unless BR2_PRIMARY_SITE_ONLY is set
|
|
#
|
|
# Argument 1 is the source location
|
|
#
|
|
# E.G. use like this:
|
|
# $(call DOWNLOAD,$(FOO_SITE))
|
|
#
|
|
# For PRIMARY and BACKUP site, any ? in the URL is replaced by %3F. A ? in
|
|
# the URL is used to separate query arguments, but the PRIMARY and BACKUP
|
|
# sites serve just plain files.
|
|
################################################################################
|
|
|
|
define DOWNLOAD
|
|
$(call DOWNLOAD_INNER,$(1),$(notdir $(1)),DOWNLOAD)
|
|
endef
|
|
|
|
define DOWNLOAD_INNER
|
|
$(Q)$(if $(filter bzr cvs hg svn,$($(PKG)_SITE_METHOD)),export BR_NO_CHECK_HASH_FOR=$(2);) \
|
|
if test -n "$(call qstrip,$(BR2_PRIMARY_SITE))" ; then \
|
|
case "$(call geturischeme,$(BR2_PRIMARY_SITE))" in \
|
|
file) $(call $(3)_LOCALFILES,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
|
|
scp) $(call $(3)_SCP,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
|
|
*) $(call $(3)_WGET,$(BR2_PRIMARY_SITE)/$(subst ?,%3F,$(2)),$(2)) && exit ;; \
|
|
esac ; \
|
|
fi ; \
|
|
if test "$(BR2_PRIMARY_SITE_ONLY)" = "y" ; then \
|
|
exit 1 ; \
|
|
fi ; \
|
|
if test -n "$(1)" ; then \
|
|
case "$($(PKG)_SITE_METHOD)" in \
|
|
git) $($(3)_GIT) && exit ;; \
|
|
svn) $($(3)_SVN) && exit ;; \
|
|
cvs) $($(3)_CVS) && exit ;; \
|
|
bzr) $($(3)_BZR) && exit ;; \
|
|
file) $($(3)_LOCALFILES) && exit ;; \
|
|
scp) $($(3)_SCP) && exit ;; \
|
|
hg) $($(3)_HG) && exit ;; \
|
|
*) $(call $(3)_WGET,$(1),$(2)) && exit ;; \
|
|
esac ; \
|
|
fi ; \
|
|
if test -n "$(call qstrip,$(BR2_BACKUP_SITE))" ; then \
|
|
$(call $(3)_WGET,$(BR2_BACKUP_SITE)/$(subst ?,%3F,$(2)),$(2)) && exit ; \
|
|
fi ; \
|
|
exit 1
|
|
endef
|