From 01a7dae0f87d2919db8dffed94c166d0de076839 Mon Sep 17 00:00:00 2001 From: emteere <47253321+emteere@users.noreply.github.com> Date: Fri, 18 Oct 2019 00:12:11 -0400 Subject: [PATCH] GT-3221_emteere sped up data chain fixup by 1/3 --- .../ghidra/app/util/opinion/DyldCacheProgramBuilder.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/opinion/DyldCacheProgramBuilder.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/opinion/DyldCacheProgramBuilder.java index bdcbeff866..90b50112bf 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/opinion/DyldCacheProgramBuilder.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/opinion/DyldCacheProgramBuilder.java @@ -42,6 +42,7 @@ import ghidra.program.model.address.AddressSpace; import ghidra.program.model.data.DataUtilities; import ghidra.program.model.data.Pointer64DataType; import ghidra.program.model.listing.CodeUnit; +import ghidra.program.model.listing.Data; import ghidra.program.model.listing.Program; import ghidra.program.model.listing.ProgramFragment; import ghidra.program.model.mem.MemoryAccessException; @@ -357,8 +358,8 @@ public class DyldCacheProgramBuilder extends MachoProgramBuilder { // create a pointer at the fixed up chain pointer location try { - DataUtilities.createData(program,chainLoc, Pointer64DataType.dataType, -1, false, - DataUtilities.ClearDataMode.CLEAR_ALL_UNDEFINED_CONFLICT_DATA); + // don't use data utilities. does too much extra checking work + listing.createData(chainLoc, Pointer64DataType.dataType); } catch (CodeUnitInsertionException e) { // No worries, something presumably more important was there already