From d48d346d7cd0d8c754e8e4faa60fdec1694c730f Mon Sep 17 00:00:00 2001 From: Jakub Stasiak Date: Sat, 7 Feb 2026 16:20:49 +0100 Subject: [PATCH 1/2] Improve the Namespace.getName() documentation This is a bunch of more or less related improvements, hence all of it bundled in one commit: * Better terminology * Cross-references where applicable * Fixed getName(boolean) claiming that it returned "fully qualified name" unconditionally --- .../java/ghidra/program/model/symbol/Namespace.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Namespace.java b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Namespace.java index 7f5b6a51ea..7ba1914b3f 100644 --- a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Namespace.java +++ b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Namespace.java @@ -81,15 +81,18 @@ public interface Namespace { public boolean isExternal(); /** - * Get the name of the symbol for this scope - * @return the name of the symbol for this scope + * Get the simple namespace name (without parent path). + * See {@link #getName(boolean)} for the namespace-qualified variant. + * @return the simple namespace name */ public String getName(); /** - * Returns the fully qualified name - * @param includeNamespacePath true to include the namespace in the returned name - * @return the fully qualified name + * Returns the namespace name, optionally prepended with the full parent namespace path. + * @param includeNamespacePath true to include the namespace path + * (using {@link #DELIMITER} as separator) in the returned name + * @return the simple name if {@code includeNamespacePath} is false, or the full + * namespace-qualified name (e.g., {@code "ClassA::InnerClass"}) if true */ public String getName(boolean includeNamespacePath); From a7801a882dc1281f255f81c7868d32dcd8d6b7ac Mon Sep 17 00:00:00 2001 From: Ryan Kurtz Date: Wed, 11 Feb 2026 06:41:18 -0500 Subject: [PATCH 2/2] GP-0: Javadoc tweak --- .../src/main/java/ghidra/program/model/symbol/Namespace.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Namespace.java b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Namespace.java index 7ba1914b3f..2d800eb21e 100644 --- a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Namespace.java +++ b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Namespace.java @@ -81,9 +81,9 @@ public interface Namespace { public boolean isExternal(); /** - * Get the simple namespace name (without parent path). + * {@return the simple namespace name (without parent path)} + *

* See {@link #getName(boolean)} for the namespace-qualified variant. - * @return the simple namespace name */ public String getName();