From 1287e4c807c0cfe38d47749c2dcd47ebfb345a8b Mon Sep 17 00:00:00 2001 From: dragonmacher <48328597+dragonmacher@users.noreply.github.com> Date: Wed, 8 May 2019 11:34:53 -0400 Subject: [PATCH] GT-2846, 2847 - Decompiler - test fixes --- .../app/util/viewer/listingpanel/ProgramBigListingModel.java | 4 ++++ .../ghidra/app/util/viewer/field/OperandFieldFactoryTest.java | 4 ---- .../app/util/viewer/field/PostCommentFieldFactoryTest.java | 4 ---- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/viewer/listingpanel/ProgramBigListingModel.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/viewer/listingpanel/ProgramBigListingModel.java index 7a349db52d..40325982f7 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/viewer/listingpanel/ProgramBigListingModel.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/viewer/listingpanel/ProgramBigListingModel.java @@ -91,6 +91,10 @@ public class ProgramBigListingModel implements ListingModel, FormatModelListener showNonExternalFunctionPointerFormat = (Boolean) newValue; formatModelChanged(null); } + + // There are quite a few options that affect the display of the the layouts. Flush + // the cache on any change, as it is simpler than tracking individual options. + layoutCache.clear(); } @Override diff --git a/Ghidra/Features/Base/src/test.slow/java/ghidra/app/util/viewer/field/OperandFieldFactoryTest.java b/Ghidra/Features/Base/src/test.slow/java/ghidra/app/util/viewer/field/OperandFieldFactoryTest.java index 5aa18e7ac0..8d3eee5bd4 100644 --- a/Ghidra/Features/Base/src/test.slow/java/ghidra/app/util/viewer/field/OperandFieldFactoryTest.java +++ b/Ghidra/Features/Base/src/test.slow/java/ghidra/app/util/viewer/field/OperandFieldFactoryTest.java @@ -56,10 +56,6 @@ public class OperandFieldFactoryTest extends AbstractGhidraHeadedIntegrationTest private Options fieldOptions; private Program program; - public OperandFieldFactoryTest() { - super(); - } - @Before public void setUp() throws Exception { diff --git a/Ghidra/Features/Base/src/test.slow/java/ghidra/app/util/viewer/field/PostCommentFieldFactoryTest.java b/Ghidra/Features/Base/src/test.slow/java/ghidra/app/util/viewer/field/PostCommentFieldFactoryTest.java index d888d05986..95cfdb90bd 100644 --- a/Ghidra/Features/Base/src/test.slow/java/ghidra/app/util/viewer/field/PostCommentFieldFactoryTest.java +++ b/Ghidra/Features/Base/src/test.slow/java/ghidra/app/util/viewer/field/PostCommentFieldFactoryTest.java @@ -41,10 +41,6 @@ public class PostCommentFieldFactoryTest extends AbstractGhidraHeadedIntegration private Options fieldOptions; private Program program; - public PostCommentFieldFactoryTest() { - super(); - } - @Before public void setUp() throws Exception {