From 131fdd9df16162170f1fbb2c8f9e198fe9db3b1a Mon Sep 17 00:00:00 2001 From: Ryan Kurtz Date: Mon, 20 Mar 2023 07:41:30 -0400 Subject: [PATCH] GP-0: PR cleanup --- .../java/ghidra/app/util/bin/format/omf/OmfFileHeader.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/omf/OmfFileHeader.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/omf/OmfFileHeader.java index 681d012b50..18a7d67ce0 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/omf/OmfFileHeader.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/omf/OmfFileHeader.java @@ -351,7 +351,7 @@ public class OmfFileHeader extends OmfRecord { header.groups.add(group); } else if (record instanceof OmfFixupRecord fixuprec) { - if(lastDataBlock != null) { + if (lastDataBlock != null) { fixuprec.setDataBlock(lastDataBlock); header.fixup.add(fixuprec); } @@ -370,6 +370,7 @@ public class OmfFileHeader extends OmfRecord { lastDataBlock = iterheader; } else if (record instanceof OmfUnsupportedRecord) { + // TODO: Should we always set lastDataBlock to null? if (record.getRecordType() == COMDAT) { lastDataBlock = null; }