mirror/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-09-28 17:11:11 -09:00
Code Issues Packages Projects Releases Wiki Activity

GP-0: Fix exit code for "not found" (after GP-994)

Browse Source
This commit is contained in:
Dan
2022-11-14 12:33:16 -05:00
parent 9188a519dc
commit 13dc22099b
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Ghidra/Debug/Debugger-agent-gdb/src/main/java/agent/gdb/pty/linux/LinuxPtySessionLeader.java
View File

@@ -79,7 +79,7 @@ public class LinuxPtySessionLeader {
} }
} }
System.err.println("Could not execute " + subArgs.get(0) + ": " + t.getMessage()); System.err.println("Could not execute " + subArgs.get(0) + ": " + t.getMessage());
System.exit(-1); System.exit(127);
} }
} }
} }

5
Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/pty/linux/LinuxPtyTest.java
View File

@@ -84,10 +84,9 @@ public class LinuxPtyTest extends AbstractPtyTest {
PtySession dies = PtySession dies =
pty.getChild().session(new String[] { "thisHadBetterNotExist" }, null); pty.getChild().session(new String[] { "thisHadBetterNotExist" }, null);
/** /**
* NOTE: Java subprocess dies with code 1 on unhandled exception. TODO: Is there a nice * Choice of 127 is based on bash setting "exit code" to 127 for "command not found"
* way to distinguish whether the code is from java or the execed image?
*/ */
assertEquals(1, dies.waitExited()); assertEquals(127, dies.waitExited());
} }
} }