From 79d31b2e1c61c5fdd59c7713bd165d892890df54 Mon Sep 17 00:00:00 2001 From: dragonmacher <48328597+dragonmacher@users.noreply.github.com> Date: Tue, 2 Jun 2026 14:42:09 -0400 Subject: [PATCH] GP-6906 - Fixed analysis options dialog checkbox key binding not working --- .../ghidra/app/plugin/core/analysis/AnalysisPanel.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/analysis/AnalysisPanel.java b/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/analysis/AnalysisPanel.java index e817e50a7d..e4fbff128d 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/analysis/AnalysisPanel.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/analysis/AnalysisPanel.java @@ -453,6 +453,8 @@ class AnalysisPanel extends JPanel implements PropertyChangeListener { boolean enabledState = (Boolean) model.getValueAt(row, column); model.setValueAt(!enabledState, row, column); } + + e.consume(); } } }); @@ -498,9 +500,7 @@ class AnalysisPanel extends JPanel implements PropertyChangeListener { void setAnalyzerEnabled(String analyzerName, boolean enabled, boolean fireEvent) { List list = analyzerManagedComponentsMap.get(analyzerName); if (list != null) { - Iterator iterator = list.iterator(); - while (iterator.hasNext()) { - Component next = iterator.next(); + for (Component next : list) { next.setEnabled(enabled); } } @@ -914,7 +914,7 @@ class AnalysisPanel extends JPanel implements PropertyChangeListener { optionsComboBox.addItemListener(optionsComboBoxListener); return; } - selectedOptions = (FileOptions) optionsComboBox.getSelectedItem(); + selectedOptions = optionsComboBox.getSelectedItem(); updateDeleteButton(); loadCurrentOptionsIntoEditors(); propertyChangeListener.propertyChange(