From 256e7e607c95f148ecc2af6e32dfd937384d89a2 Mon Sep 17 00:00:00 2001 From: Dan <46821332+nsadeveloper789@users.noreply.github.com> Date: Mon, 26 Apr 2021 10:39:15 -0400 Subject: [PATCH] GP-0: Change tests from 'echo' to 'expPrint', as it's better controlled. --- .../gdb/model/AbstractModelForGdbAmd64RegistersTest.java | 2 +- .../agent/gdb/model/AbstractModelForGdbBreakpointsTest.java | 2 +- .../agent/gdb/model/AbstractModelForGdbInterpreterTest.java | 2 +- .../agent/gdb/model/AbstractModelForGdbLauncherTest.java | 2 +- .../agent/gdb/model/AbstractModelForGdbSteppableTest.java | 2 +- .../gdb/model/AbstractModelForGdbThreadActivationTest.java | 2 +- .../src/test/java/agent/gdb/model/GdbLinuxSpecimen.java | 6 ------ 7 files changed, 6 insertions(+), 12 deletions(-) diff --git a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbAmd64RegistersTest.java b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbAmd64RegistersTest.java index 703dd4af96..46458f84fa 100644 --- a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbAmd64RegistersTest.java +++ b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbAmd64RegistersTest.java @@ -54,6 +54,6 @@ public abstract class AbstractModelForGdbAmd64RegistersTest */ @Override public DebuggerTestSpecimen getLaunchSpecimen() { - return GdbLinuxSpecimen.ECHO_HW; + return GdbLinuxSpecimen.PRINT; } } diff --git a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbBreakpointsTest.java b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbBreakpointsTest.java index 93b40fe1ed..3dd9fb92eb 100644 --- a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbBreakpointsTest.java +++ b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbBreakpointsTest.java @@ -43,7 +43,7 @@ public abstract class AbstractModelForGdbBreakpointsTest @Override public DebuggerTestSpecimen getLaunchSpecimen() { - return GdbLinuxSpecimen.ECHO_HW; + return GdbLinuxSpecimen.PRINT; } @Override diff --git a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbInterpreterTest.java b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbInterpreterTest.java index 3d2289a630..d2840e7343 100644 --- a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbInterpreterTest.java +++ b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbInterpreterTest.java @@ -59,6 +59,6 @@ public abstract class AbstractModelForGdbInterpreterTest @Override public DebuggerTestSpecimen getLaunchSpecimen() { - return GdbLinuxSpecimen.ECHO_HW; + return GdbLinuxSpecimen.PRINT; } } diff --git a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbLauncherTest.java b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbLauncherTest.java index 9dae006f11..c3d2ad8a95 100644 --- a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbLauncherTest.java +++ b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbLauncherTest.java @@ -29,7 +29,7 @@ public abstract class AbstractModelForGdbLauncherTest extends AbstractDebuggerMo @Override public DebuggerTestSpecimen getLaunchSpecimen() { - return GdbLinuxSpecimen.ECHO_HW; + return GdbLinuxSpecimen.PRINT; } @Override diff --git a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbSteppableTest.java b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbSteppableTest.java index d0d4f62b61..a6678c3921 100644 --- a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbSteppableTest.java +++ b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbSteppableTest.java @@ -34,6 +34,6 @@ public abstract class AbstractModelForGdbSteppableTest extends AbstractDebuggerM @Override public DebuggerTestSpecimen getLaunchSpecimen() { - return GdbLinuxSpecimen.ECHO_HW; + return GdbLinuxSpecimen.PRINT; } } diff --git a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbThreadActivationTest.java b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbThreadActivationTest.java index fc49a0eabb..f739e8dbe9 100644 --- a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbThreadActivationTest.java +++ b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/AbstractModelForGdbThreadActivationTest.java @@ -36,7 +36,7 @@ public abstract class AbstractModelForGdbThreadActivationTest new PathPattern(PathUtils.parse("Inferiors[].Threads[]")); protected DebuggerTestSpecimen getSpecimen() { - return GdbLinuxSpecimen.ECHO_HW; + return GdbLinuxSpecimen.PRINT; } @Override diff --git a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/GdbLinuxSpecimen.java b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/GdbLinuxSpecimen.java index 3965ce71fe..0c57e922fe 100644 --- a/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/GdbLinuxSpecimen.java +++ b/Ghidra/Debug/Debugger-agent-gdb/src/test/java/agent/gdb/model/GdbLinuxSpecimen.java @@ -28,12 +28,6 @@ import ghidra.dbg.testutil.DummyProc; import ghidra.dbg.util.ShellUtils; public enum GdbLinuxSpecimen implements DebuggerTestSpecimen, DebuggerModelTestUtils { - ECHO_HW { - @Override - String getCommandLine() { - return "/bin/echo Hello, World!"; - } - }, DD { @Override String getCommandLine() {