mirror/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-09-28 17:11:11 -09:00
Code Issues Packages Projects Releases Wiki Activity

GP-4759 corrected BigFloat formatting of -0.0 (Closes #6677)

Browse Source
This commit is contained in:
ghidra1
2024-07-08 22:34:43 -04:00
parent 76923e15b3
commit 282c6b698a
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/pcode/floatformat/BigFloat.java
View File

@@ -1042,6 +1042,9 @@ public class BigFloat implements Comparable<BigFloat> {
if (isInfinite()) { if (isInfinite()) {
return sign < 0 ? NEGATIVE_INFINITY : POSITIVE_INFINITY; return sign < 0 ? NEGATIVE_INFINITY : POSITIVE_INFINITY;
} }
if (isZero()) {
return sign < 0 ? "-0.0" : "0.0";
}
return null; return null;
} }

6
Ghidra/Framework/SoftwareModeling/src/test/java/ghidra/pcode/floatformat/FloatFormatTest.java
View File

@@ -1480,7 +1480,11 @@ public class FloatFormatTest extends AbstractGenericTest {
@Test @Test
public void testValueOfBigInteger() { public void testValueOfBigInteger() {
FloatFormat ff = FloatFormatFactory.getFloatFormat(8); FloatFormat ff = FloatFormatFactory.getFloatFormat(8);
assertEquals("0.0", ff.toDecimalString(ff.getBigFloat(BigInteger.ZERO)));
assertFalse(ff.getBigZero(true).equals(ff.getBigZero(false)));
assertEquals("-0.0", ff.toDecimalString(ff.getBigZero(true)));
assertEquals("0.0", ff.toDecimalString(ff.getBigZero(false)));
assertEquals("1.0", ff.toDecimalString(ff.getBigFloat(BigInteger.ONE))); assertEquals("1.0", ff.toDecimalString(ff.getBigFloat(BigInteger.ONE)));
assertEquals("2.0", ff.toDecimalString(ff.getBigFloat(BigInteger.TWO))); assertEquals("2.0", ff.toDecimalString(ff.getBigFloat(BigInteger.TWO)));
assertEquals("-1.0", ff.toDecimalString(ff.getBigFloat(BigInteger.ONE.negate()))); assertEquals("-1.0", ff.toDecimalString(ff.getBigFloat(BigInteger.ONE.negate())));