mirror/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-09-19 16:40:38 -09:00
Code Issues Packages Projects Releases Wiki Activity

GP-6076 - Find All - Added a button to the Find dialog to find all matches and show the results in a table

Browse Source
This commit is contained in:
dragonmacher
2025-11-12 12:34:30 -05:00
parent 2597c243b9
commit 2ae42befb8
63 changed files with 3131 additions and 1273 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Ghidra/Features/CodeCompare/src/main/java/ghidra/features/codecompare/decompile/DecompilerDiffViewFindAction.java
View File

@@ -87,7 +87,7 @@ public class DecompilerDiffViewFindAction extends DockingAction {
private FindDialog createFindDialog(DecompilerPanel decompilerPanel, Side side) {
String title = (side == LEFT ? "Left" : "Right");
title += " Decompiler Find Text";
title += " Decompiler Find";
FindDialog dialog = new FindDialog(title, new DecompilerSearcher(decompilerPanel)) {
@Override
@@ -98,6 +98,15 @@ public class DecompilerDiffViewFindAction extends DockingAction {
};
dialog.setHelpLocation(new HelpLocation(HelpTopics.DECOMPILER, "ActionFind"));
/*
Find All will keep the results around in a separate window. When those results are
clicked, the Decompiler will update the current function. This can cause the function
comparison window to become out of sync with the available functions being compared. We
could update the function comparison to handle this case, but that doesn't seem worth it
at this time. For now, just disable the Find All.
*/
dialog.setFindAllEnabled(false);
return dialog;
}