mirror/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-09-28 17:11:11 -09:00
Code Issues Packages Projects Releases Wiki Activity

GP-3261 Strip PartialUnion in NoisyStructureBuilder

Browse Source
This commit is contained in:
caheckman
2023-03-24 15:41:20 -04:00
parent 7e416ac789
commit 2b5ef59d87
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/data/NoisyStructureBuilder.java
View File

@@ -19,6 +19,8 @@ import java.util.Iterator;
import java.util.Map.Entry; import java.util.Map.Entry;
import java.util.TreeMap; import java.util.TreeMap;
import ghidra.program.model.pcode.PartialUnion;
/** /**
* Build a structure from a "noisy" source of field information. * Build a structure from a "noisy" source of field information.
* Feed it field records, either via addDataType(), when we * Feed it field records, either via addDataType(), when we
@@ -92,6 +94,11 @@ public class NoisyStructureBuilder {
dt = manager.getPointer(DataType.DEFAULT, dt.getLength()); dt = manager.getPointer(DataType.DEFAULT, dt.getLength());
} }
} }
else if (dt instanceof PartialUnion) {
// The decompiler can produce the internal data-type PartialUnion, which must
// be replaced with a suitable formal data-type within the structure being built
dt = ((PartialUnion) dt).getStrippedDataType();
}
computeMax(offset, dt.getLength()); computeMax(offset, dt.getLength());
Entry<Long, DataType> firstEntry = checkForOverlap(offset, dt.getLength()); Entry<Long, DataType> firstEntry = checkForOverlap(offset, dt.getLength());
if (firstEntry != null) { if (firstEntry != null) {

7
Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/pcode/PartialUnion.java
View File

@@ -119,4 +119,11 @@ public class PartialUnion extends AbstractDataType {
return 0; return 0;
} }
/**
* Get a data-type that can be used as a formal replacement for this (internal) data-type
* @return a replacement data-type
*/
public DataType getStrippedDataType() {
return Undefined.getUndefinedDataType(size);
}
} }