From eb507229eb6eaa604c2cc77f198c3c2c15dabe5e Mon Sep 17 00:00:00 2001 From: dev747368 <48332326+dev747368@users.noreply.github.com> Date: Mon, 28 Nov 2022 23:38:12 +0000 Subject: [PATCH 1/2] GP-2852 fix svrAdmin when repo name contains a space --- .../GhidraServer/src/main/java/ghidra/server/ServerAdmin.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Ghidra/Features/GhidraServer/src/main/java/ghidra/server/ServerAdmin.java b/Ghidra/Features/GhidraServer/src/main/java/ghidra/server/ServerAdmin.java index 8ad0c87313..f74c604142 100644 --- a/Ghidra/Features/GhidraServer/src/main/java/ghidra/server/ServerAdmin.java +++ b/Ghidra/Features/GhidraServer/src/main/java/ghidra/server/ServerAdmin.java @@ -456,6 +456,9 @@ public class ServerAdmin implements GhidraLaunchable { Msg.error(CommandProcessor.class, "Repository not found: " + repName); System.exit(-1); } + if (repName.contains(" ")) { + args[i] = "\"" + repName + "\""; + } } /** From bbe86e0ae679e8559444c40c45ad58db69c7b398 Mon Sep 17 00:00:00 2001 From: ghidra1 Date: Tue, 29 Nov 2022 11:32:25 -0500 Subject: [PATCH 2/2] GP-0 updated launch.properties with optional network troubleshooting VMARG --- .../RuntimeScripts/Common/support/launch.properties | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Ghidra/RuntimeScripts/Common/support/launch.properties b/Ghidra/RuntimeScripts/Common/support/launch.properties index b0565ab802..1a33ea6fff 100644 --- a/Ghidra/RuntimeScripts/Common/support/launch.properties +++ b/Ghidra/RuntimeScripts/Common/support/launch.properties @@ -36,6 +36,17 @@ VMARGS=-Djdk.tls.client.protocols=TLSv1.2,TLSv1.3 # specifying path to installed CA certificates file. # VMARGS=-Dghidra.cacerts= +# Enable verbose logging for network SSL/TLS negotiations. +# This can be very useful when troubleshooting SSLHandshakeException failures which can +# manifest with very cryptic messages. All Ghidra Server communications rely on secure +# SSL/TLS connections. This VMARG should only be uncommented while actively troubleshooting +# since it will log a significant amount of data. +# +# See the "Troubleshoting JSSE" section of the following internet hosted document: +# https://docs.oracle.com/en/java/javase/17/security/java-secure-socket-extension-jsse-reference-guide.html +# +#VMARGS=-Djavax.net.debug=ssl + # The following property will limit the number of processor cores that Ghidra # will use for thread pools. If not specified, it will use the default number # of processors returned from Runtime.getRuntime().getAvailableProcessors().