From 43701f073573858d4e50f755dbcb99c57ff27700 Mon Sep 17 00:00:00 2001
From: dragonmacher <48328597+dragonmacher@users.noreply.github.com>
Date: Thu, 16 May 2024 18:46:29 -0400
Subject: [PATCH] GP-4604 - Fixed stack overflow exception

---
 .../ghidra/app/plugin/core/script/ScriptList.java    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/script/ScriptList.java b/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/script/ScriptList.java
index fb5e70ae10..905a5a108e 100644
--- a/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/script/ScriptList.java
+++ b/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/script/ScriptList.java
@@ -30,14 +30,14 @@ import ghidra.util.datastruct.WeakSet;
 import ghidra.util.task.SwingUpdateManager;
 
 /**
- * Loads and manages updating of available script files.   
+ * Loads and manages updating of available script files.
  * <p>
  * Use the {@link #refresh()} method to reload the script files.
  */
 public class ScriptList {
 
 	private BundleHost bundleHost;
-	private List<ResourceFile> scriptFiles = new ArrayList<>();
+	private List<ResourceFile> scriptFiles = null;
 	private WeakSet<ChangeListener> listeners = WeakDataStructureFactory.createCopyOnWriteWeakSet();
 
 	private SwingUpdateManager refreshUpdateManager = new SwingUpdateManager(this::doRefresh);
@@ -76,7 +76,7 @@ public class ScriptList {
 
 	void load() {
 		Swing.runNow(() -> {
-			if (scriptFiles.isEmpty()) {
+			if (scriptFiles == null) {
 				doRefresh();
 			}
 		});
@@ -87,7 +87,7 @@ public class ScriptList {
 		return Collections.unmodifiableList(scriptFiles);
 	}
 
-	List<ResourceFile> getScriptDirectories() {
+	private List<ResourceFile> getScriptDirectories() {
 		return bundleHost.getGhidraBundles()
 				.stream()
 				.filter(GhidraSourceBundle.class::isInstance)
@@ -96,8 +96,8 @@ public class ScriptList {
 				.collect(Collectors.toList());
 	}
 
-	private void updateAvailableScriptFilesForDirectory(
-			List<ResourceFile> scriptAccumulator, ResourceFile directory) {
+	private void updateAvailableScriptFilesForDirectory(List<ResourceFile> scriptAccumulator,
+			ResourceFile directory) {
 		ResourceFile[] files = directory.listFiles();
 		if (files == null) {
 			return;