From 4fa8c5070f64ae0e53c88352bb641a8ec7627cf7 Mon Sep 17 00:00:00 2001 From: d-millar <33498836+d-millar@users.noreply.github.com> Date: Tue, 12 Mar 2024 21:19:40 +0000 Subject: [PATCH] GP-0_d-millar: fix for stack trace when testing --- Ghidra/Features/Sarif/src/main/java/sarif/SarifLoader.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Ghidra/Features/Sarif/src/main/java/sarif/SarifLoader.java b/Ghidra/Features/Sarif/src/main/java/sarif/SarifLoader.java index 6a2ef8cfb1..7e3447a67e 100644 --- a/Ghidra/Features/Sarif/src/main/java/sarif/SarifLoader.java +++ b/Ghidra/Features/Sarif/src/main/java/sarif/SarifLoader.java @@ -311,7 +311,7 @@ public class SarifLoader extends AbstractProgramLoader { } } - private ParseResult parse(ByteProvider provider) { + private ParseResult parse(ByteProvider provider) throws IOException { try { ProgramSarifMgr lastSarifMgr = new ProgramSarifMgr(provider); ProgramInfo lastInfo = lastSarifMgr.getProgramInfo(); @@ -321,8 +321,9 @@ public class SarifLoader extends AbstractProgramLoader { // This can happen during the import process when this loader attempts to load // a non-SARIF file (there really should be 2 methods, a speculative version and // a version that expects no exception) - Msg.trace(this, "Unable to parse SARIF for " + provider.getName(), e); - return new ParseResult(null, null); + + // This will get caught and discarded by the opinion logic + throw new IOException("Unable to parse "+provider.getName()+"as SARIF"); } }