From 653e3d8f803a73ee13c5885bb6449a58be06a7a6 Mon Sep 17 00:00:00 2001 From: ghidra007 Date: Fri, 1 Mar 2024 22:04:20 +0000 Subject: [PATCH] GP-4283 Added missing check for destination function existence when creating an implied match. --- .../ghidra/feature/vt/gui/util/ImpliedMatchUtils.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/util/ImpliedMatchUtils.java b/Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/util/ImpliedMatchUtils.java index 907950d4b5..57d3f69dc3 100644 --- a/Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/util/ImpliedMatchUtils.java +++ b/Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/util/ImpliedMatchUtils.java @@ -241,7 +241,13 @@ public class ImpliedMatchUtils { if (sourceFunction.getProgram() .getFunctionManager() .getFunctionAt(srcRefToAddress) == null) { - return null; // function may not have been created here. + return null; // source function may not have been created here. + } + + if (destinationFunction.getProgram() + .getFunctionManager() + .getFunctionAt(destRefToAddress) == null) { + return null; // destination function may not have been created here. } }