From 6e6f2641e29fbd053a39f25cc8b82f4e25789e8a Mon Sep 17 00:00:00 2001
From: dragonmacher <48328597+dragonmacher@users.noreply.github.com>
Date: Tue, 5 Jan 2021 13:08:25 -0500
Subject: [PATCH] Fixed incorrectly escaped line breaks; fixed bad loop check

---
 .../framework/plugintool/dialog/PluginDetailsPanel.java  | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Ghidra/Framework/Project/src/main/java/ghidra/framework/plugintool/dialog/PluginDetailsPanel.java b/Ghidra/Framework/Project/src/main/java/ghidra/framework/plugintool/dialog/PluginDetailsPanel.java
index 60107f5f95..88f9586575 100644
--- a/Ghidra/Framework/Project/src/main/java/ghidra/framework/plugintool/dialog/PluginDetailsPanel.java
+++ b/Ghidra/Framework/Project/src/main/java/ghidra/framework/plugintool/dialog/PluginDetailsPanel.java
@@ -29,6 +29,7 @@ import docking.actions.KeyBindingUtils;
 import ghidra.framework.plugintool.PluginConfigurationModel;
 import ghidra.framework.plugintool.util.PluginDescription;
 import ghidra.framework.plugintool.util.PluginStatus;
+import ghidra.util.HTMLUtilities;
 
 /**
  * Panel that contains a JTextPane to show plugin description information.
@@ -103,7 +104,7 @@ class PluginDetailsPanel extends AbstractDetailsPanel {
 				insertHTMLString(buffer, dependencies.get(i).getPluginClass().getName(),
 					dependencyAttrSet);
 				if (i < dependencies.size() - 1) {
-					insertHTMLString(buffer, "<BR>", dependencyAttrSet);
+					buffer.append(HTMLUtilities.BR);
 				}
 			}
 			insertHTMLLine(buffer, "", titleAttrSet);  // add a newline
@@ -122,8 +123,8 @@ class PluginDetailsPanel extends AbstractDetailsPanel {
 		else {
 			for (int i = 0; i < servicesRequired.size(); i++) {
 				insertHTMLString(buffer, servicesRequired.get(i).getName(), dependencyAttrSet);
-				if (i < dependencies.size() - 1) {
-					insertHTMLString(buffer, "<BR>", dependencyAttrSet);
+				if (i < servicesRequired.size() - 1) {
+					buffer.append(HTMLUtilities.BR);
 				}
 			}
 			insertHTMLLine(buffer, "", titleAttrSet);  // add a newline
@@ -136,7 +137,7 @@ class PluginDetailsPanel extends AbstractDetailsPanel {
 		//
 		//
 		// Optional: Actions loaded by this plugin
-		// 
+		//
 		addLoadedActionsContent(buffer, descriptor);
 
 		buffer.append("</TABLE>");