mirror/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-09-28 17:11:11 -09:00
Code Issues Packages Projects Releases Wiki Activity

GP-0: Improving bounds check in DebugDirectory.java (Closes #7271)

Browse Source
This commit is contained in:
Ryan Kurtz
2024-12-10 12:26:18 -05:00
parent ed2bc8c717
commit 97aadfa05a
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/pe/debug/DebugDirectory.java
View File

@@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
* You may obtain a copy of the License at * You may obtain a copy of the License at
* *
* http://www.apache.org/licenses/LICENSE-2.0 * http://www.apache.org/licenses/LICENSE-2.0
* *
* Unless required by applicable law or agreed to in writing, software * Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, * distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -92,8 +92,9 @@ public class DebugDirectory implements StructConverter, ByteArrayConverter {
return; return;
} }
if (sizeOfData > 0) { if (sizeOfData > 0) {
if (!validator.checkPointer(pointerToRawData)) { if (!validator.checkPointer(pointerToRawData + sizeOfData - 1)) {
Msg.error(this, "Invalid pointerToRawData " + pointerToRawData); Msg.error(this, "Invalid debug pointerToRawData + sizeOfData: 0x%x"
.formatted(pointerToRawData + sizeOfData - 1));
sizeOfData = 0; sizeOfData = 0;
reader.setPointerIndex(oldIndex); reader.setPointerIndex(oldIndex);
return; return;