From c65c60a042238162e13deef22f6588b05f25df8e Mon Sep 17 00:00:00 2001 From: dragonmacher <48328597+dragonmacher@users.noreply.github.com> Date: Wed, 10 Apr 2019 17:38:33 -0400 Subject: [PATCH] GT-2724 - review fixes --- .../java/ghidra/app/tablechooser/TableChooserDialog.java | 6 +++--- .../ghidra/app/tablechooser/TableChooserTableModel.java | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/tablechooser/TableChooserDialog.java b/Ghidra/Features/Base/src/main/java/ghidra/app/tablechooser/TableChooserDialog.java index 0678716791..f47db591e0 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/tablechooser/TableChooserDialog.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/tablechooser/TableChooserDialog.java @@ -51,7 +51,7 @@ import resources.ResourceManager; * to perform the action defined by the executor. * *

Each button press will use the selected items as the items to be processed. While the - * items are schedule to be processed, they will still be in the table, painted light gray. + * items are scheduled to be processed, they will still be in the table, painted light gray. * Attempting to reschedule any of these pending items will have no effect. Each time the * button is pressed, a new {@link SwingWorker} is created, which will put the processing into * a background thread. Further, by using multiple workers, the work will be performed in @@ -115,7 +115,7 @@ public class TableChooserDialog extends DialogComponentProvider e -> setOkEnabled(table.getSelectedRowCount() > 0)); GhidraTableFilterPanel filterPanel = - new GhidraTableFilterPanel(table, model); + new GhidraTableFilterPanel<>(table, model); panel.add(tablePanel, BorderLayout.CENTER); panel.add(filterPanel, BorderLayout.SOUTH); return panel; @@ -270,7 +270,7 @@ public class TableChooserDialog extends DialogComponentProvider private List doProcessRowObjects(List rowObjects, TaskMonitor monitor) { - List deleted = new ArrayList(); + List deleted = new ArrayList<>(); for (AddressableRowObject rowObject : rowObjects) { if (monitor.isCancelled()) { break; diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/tablechooser/TableChooserTableModel.java b/Ghidra/Features/Base/src/main/java/ghidra/app/tablechooser/TableChooserTableModel.java index ff13222f5b..93bb78659c 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/tablechooser/TableChooserTableModel.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/tablechooser/TableChooserTableModel.java @@ -30,7 +30,7 @@ import ghidra.util.task.TaskMonitor; public class TableChooserTableModel extends AddressBasedTableModel { // we maintain this list so that any future reload operations can load the original user data - // (this downside of this is that two lists are maintained) + // (the downside of this is that two lists are maintained) Set myPrivateList = new HashSet(); public TableChooserTableModel(String title, ServiceProvider serviceProvider, Program program,