From d70053c11ba7d73656d073cde8f6d1d24a63dfe1 Mon Sep 17 00:00:00 2001 From: Dan <46821332+nsadeveloper789@users.noreply.github.com> Date: Wed, 20 Oct 2021 13:34:57 -0400 Subject: [PATCH] GP-1395: Review changes. --- .../gui/breakpoint/DebuggerBreakpointMarkerPlugin.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Ghidra/Debug/Debugger/src/main/java/ghidra/app/plugin/core/debug/gui/breakpoint/DebuggerBreakpointMarkerPlugin.java b/Ghidra/Debug/Debugger/src/main/java/ghidra/app/plugin/core/debug/gui/breakpoint/DebuggerBreakpointMarkerPlugin.java index abb8bf5e2b..f3825cb243 100644 --- a/Ghidra/Debug/Debugger/src/main/java/ghidra/app/plugin/core/debug/gui/breakpoint/DebuggerBreakpointMarkerPlugin.java +++ b/Ghidra/Debug/Debugger/src/main/java/ghidra/app/plugin/core/debug/gui/breakpoint/DebuggerBreakpointMarkerPlugin.java @@ -965,7 +965,7 @@ public class DebuggerBreakpointMarkerPlugin extends Plugin */ Trace trace = getTraceFromContext(context); boolean mapped = breakpointService.anyMapped(bs, trace); - Enablement toggled = en = en.getToggled(mapped); + Enablement toggled = en.getToggled(mapped); if (toggled.enabled) { breakpointService.enableAll(bs, trace).exceptionally(ex -> { breakpointError(title, "Could not enable breakpoints", ex); @@ -1049,10 +1049,12 @@ public class DebuggerBreakpointMarkerPlugin extends Plugin @AutoServiceConsumed private void setMarkerService(MarkerService markerService) { + if (this.markerService != null) { + this.markerService.setMarkerClickedListener(null); + } this.markerService = markerService; - // NB. There's no way to remove such a listener... - if (markerService != null) { - markerService.setMarkerClickedListener(markerClickedListener); + if (this.markerService != null) { + this.markerService.setMarkerClickedListener(markerClickedListener); } }