From d817b073885ff86ee9606df80fe71662624e8874 Mon Sep 17 00:00:00 2001 From: Matthew Duggan Date: Tue, 22 Sep 2026 20:43:04 +1000 Subject: [PATCH] Fix display of integer arrays In e0aae02, the `++` was dropped from the index reference in this loop, but that means the first item on each row of an integer array is incorrectly repeated. Restore the ++ so the array index is incremented across the line. --- .../ghidra/app/util/viewer/field/ArrayValuesFieldFactory.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/viewer/field/ArrayValuesFieldFactory.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/viewer/field/ArrayValuesFieldFactory.java index 886556e985..8b32135e93 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/viewer/field/ArrayValuesFieldFactory.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/viewer/field/ArrayValuesFieldFactory.java @@ -102,7 +102,7 @@ public class ArrayValuesFieldFactory extends FieldFactory { List elements = new ArrayList<>(); for (int i = 0; i < itemCount; i++) { - Data child = parent.getComponent(index); + Data child = parent.getComponent(index++); boolean isLastItem = isLastLine && (i == itemCount - 1); String value = getDisplayValue(child, !isLastItem); AttributedString as =