From e44daf55aaa511c128e1e9233eb9d7c27a4c02b8 Mon Sep 17 00:00:00 2001 From: dragonmacher <48328597+dragonmacher@users.noreply.github.com> Date: Sat, 17 Feb 2024 11:21:31 -0500 Subject: [PATCH] GP-4317 - Removing the 'reserved' concept --- .../ActivatorExampleScript.java | 5 +- .../help/topics/Tool/ToolOptions_Dialog.htm | 9 +- .../core/script/KeyBindingInputDialog.java | 15 +- .../app/plugin/debug/ComponentInfoPlugin.java | 2 +- .../dialog/KeyBindingUtilsTest.java | 13 +- .../plugintool/dialog/KeyBindingsTest.java | 302 +++++++++++----- .../bean/opteditor/OptionsDialogTest.java | 27 +- .../java/docking/DockingKeyBindingAction.java | 4 +- .../KeyBindingOverrideKeyEventDispatcher.java | 24 +- .../java/docking/KeyBindingPrecedence.java | 12 +- .../main/java/docking/KeyEntryTextField.java | 22 +- .../docking/action/AbstractHelpAction.java | 156 +++++++++ .../action/ComponentThemeInspectorAction.java | 10 +- .../java/docking/action/DockingAction.java | 8 +- .../action/GlobalFocusTraversalAction.java | 2 +- .../main/java/docking/action/HelpAction.java | 125 +------ ...BindingAction.java => HelpInfoAction.java} | 15 +- .../java/docking/action/KeyBindingData.java | 14 +- .../docking/action/KeyBindingsManager.java | 141 +++++--- .../docking/action/MultipleKeyAction.java | 8 +- .../action/NextPreviousWindowAction.java | 2 +- .../docking/action/ShowContextMenuAction.java | 15 +- .../docking/action/ShowFocusCycleAction.java | 6 +- .../docking/action/ShowFocusInfoAction.java | 6 +- .../action/SystemKeyBindingAction.java | 45 +++ .../docking/actions/DockingToolActions.java | 3 +- .../java/docking/actions/KeyBindings.java | 262 ++++++++++++++ .../java/docking/actions/KeyEntryDialog.java | 91 ++--- ...ngAction.java => SetKeyBindingAction.java} | 18 +- .../java/docking/actions/ToolActions.java | 82 +++-- .../util/action/ReservedKeyBindings.java | 94 ----- .../util/action/SystemKeyBindings.java | 58 +++ .../src/main/resources/generic.log4jdev.xml | 5 +- .../src/main/resources/generic.log4jtest.xml | 3 + .../java/generic/test/AbstractGuiTest.java | 16 +- .../framework/data/DefaultProjectData.java | 3 - .../plugintool/dialog/KeyBindingsPanel.java | 330 +++++------------- .../plugintool/mgr/OptionsManager.java | 2 +- .../project/tool/GhidraToolTemplate.java | 17 +- .../java/help/screenshot/ToolScreenShots.java | 5 +- 40 files changed, 1143 insertions(+), 834 deletions(-) create mode 100644 Ghidra/Framework/Docking/src/main/java/docking/action/AbstractHelpAction.java rename Ghidra/Framework/Docking/src/main/java/docking/action/{ReservedKeyBindingAction.java => HelpInfoAction.java} (64%) create mode 100644 Ghidra/Framework/Docking/src/main/java/docking/action/SystemKeyBindingAction.java create mode 100644 Ghidra/Framework/Docking/src/main/java/docking/actions/KeyBindings.java rename Ghidra/Framework/Docking/src/main/java/docking/actions/{KeyBindingAction.java => SetKeyBindingAction.java} (87%) delete mode 100644 Ghidra/Framework/Generic/src/main/java/generic/util/action/ReservedKeyBindings.java create mode 100644 Ghidra/Framework/Generic/src/main/java/generic/util/action/SystemKeyBindings.java diff --git a/Ghidra/Extensions/bundle_examples/scripts_with_activator/ActivatorExampleScript.java b/Ghidra/Extensions/bundle_examples/scripts_with_activator/ActivatorExampleScript.java index 756186ae17..ce77e697ac 100644 --- a/Ghidra/Extensions/bundle_examples/scripts_with_activator/ActivatorExampleScript.java +++ b/Ghidra/Extensions/bundle_examples/scripts_with_activator/ActivatorExampleScript.java @@ -17,7 +17,8 @@ //@category Examples.Bundle import docking.ActionContext; -import docking.action.*; +import docking.action.DockingAction; +import docking.action.ToolBarData; import ghidra.app.script.GhidraScript; import ghidra.app.services.CodeViewerService; import ghidra.app.services.ConsoleService; @@ -40,7 +41,7 @@ public class ActivatorExampleScript extends GhidraScript { println("The activator will remove the action if this bundle is deactivated,"); println(" e.g. if this script is modified and the bundle needs to be reloaded."); - DockingAction action = new DockingAction("Added by script!!", null, false) { + DockingAction action = new DockingAction("Added by script!!", null) { @Override public void actionPerformed(ActionContext context) { ConsoleService console = tool.getService(ConsoleService.class); diff --git a/Ghidra/Features/Base/src/main/help/help/topics/Tool/ToolOptions_Dialog.htm b/Ghidra/Features/Base/src/main/help/help/topics/Tool/ToolOptions_Dialog.htm index 5adc29b190..f65a794c98 100644 --- a/Ghidra/Features/Base/src/main/help/help/topics/Tool/ToolOptions_Dialog.htm +++ b/Ghidra/Features/Base/src/main/help/help/topics/Tool/ToolOptions_Dialog.htm @@ -59,9 +59,12 @@ the tool options. For example, the following keys cannot be changed: