GP-2868 - Image Cleanup - Removed unused images; removed duplicate

images; fixed image module dependency issues

Ghidra/Framework/Project/certification.manifest

@@ -20,34 +20,21 @@ src/main/java/ghidra/framework/plugintool/util/package.html||GHIDRA||||END|
 src/main/java/ghidra/framework/project/package.html||GHIDRA||||END|
 src/main/java/ghidra/framework/project/tool/package.html||GHIDRA||||END|
 src/main/resources/images/Minus.png||GHIDRA||||END|
-src/main/resources/images/Plus.png||GHIDRA||||END|
-src/main/resources/images/allInTool.gif||GHIDRA||reviewed||END|
 src/main/resources/images/applications-development-web.png||Oxygen Icons - LGPL 3.0|||Oxygen icon theme (dual license; LGPL or CC-SA-3.0)|END|
 src/main/resources/images/applications-science.png||Oxygen Icons - LGPL 3.0||||END|
-src/main/resources/images/bug.png||FAMFAMFAM Icons - CC 2.5|||famfamfam silk icon set|END|
 src/main/resources/images/checkNotLatest.gif||GHIDRA||reviewed||END|
 src/main/resources/images/checkex.png||GHIDRA||reviewed||END|
-src/main/resources/images/checkmark_green.gif||GHIDRA||reviewed||END|
 src/main/resources/images/connected.gif||GHIDRA||reviewed||END|
-src/main/resources/images/cut_red.png||FAMFAMFAM Icons - CC 2.5||||END|
-src/main/resources/images/defaultIndicator.png||GHIDRA||reviewed||END|
-src/main/resources/images/dialog-cancel.png||Oxygen Icons - LGPL 3.0||||END|
 src/main/resources/images/disconnected.gif||GHIDRA||reviewed||END|
-src/main/resources/images/disk.png||FAMFAMFAM Icons - CC 2.5||||END|
-src/main/resources/images/face-glasses.png||Tango Icons - Public Domain|||tango icon set|END|
-src/main/resources/images/folder_add.png||FAMFAMFAM Icons - CC 2.5|||famfamfam silk icon set|END|
 src/main/resources/images/link.png||Crystal Clear Icons - LGPL 2.1||||END|
 src/main/resources/images/lock.png||FAMFAMFAM Icons - CC 2.5|||famfamfam silk icon set|END|
 src/main/resources/images/monitor.png||FAMFAMFAM Icons - CC 2.5|||silk|END|
-src/main/resources/images/noneInTool.gif||GHIDRA||reviewed||END|
 src/main/resources/images/page_add.png||FAMFAMFAM Icons - CC 2.5||||END|
-src/main/resources/images/page_copy.png||FAMFAMFAM Icons - CC 2.5||||END|
 src/main/resources/images/page_delete.png||FAMFAMFAM Icons - CC 2.5||||END|
 src/main/resources/images/page_edit.png||FAMFAMFAM Icons - CC 2.5||||END|
 src/main/resources/images/plasma.png||Oxygen Icons - LGPL 3.0|||Oxygen icon theme (dual license; LGPL or CC-SA-3.0)|END|
 src/main/resources/images/plugin.png||GHIDRA||reviewed||END|
 src/main/resources/images/small_hijack.gif||GHIDRA||reviewed||END|
-src/main/resources/images/someInTool.gif||GHIDRA||reviewed||END|
 src/main/resources/images/undo_hijack.png||GHIDRA||reviewed||END|
 src/main/resources/images/unknownFile.gif||GHIDRA||reviewed||END|
 src/main/resources/images/user-busy.png||Oxygen Icons - LGPL 3.0|||Oxygen icon theme (dual license; LGPL or CC-SA-3.0)|END|
@@ -60,4 +47,3 @@ src/main/resources/images/vcUndoCheckOut.png||GHIDRA||reviewed||END|
 src/main/resources/images/view-refresh.png||Tango Icons - Public Domain||||END|
 src/main/resources/images/view_detailed.png||Crystal Clear Icons - LGPL 2.1||||END|
 src/main/resources/images/wand.png||FAMFAMFAM Icons - CC 2.5|||famfamfam silk icon set|END|
-src/main/resources/images/warning.png||FAMFAMFAM Icons - CC 2.5|||famfamfam silk icon set|END|

Ghidra/Framework/Project/data/project.theme.properties

@@ -43,6 +43,8 @@ color.fg.logviewer.table.selected = black
 color.bg.project.access.panel.table.selection = lavender
 color.fg.project.access.panel.table.selection = black
 
+icon.domain.file.uknown = unknownFile.gif
+
 icon.version.control.add = vcAdd.png
 icon.version.control.check.in = vcCheckIn.png
 icon.version.control.check.out = vcCheckOut.png
@@ -52,7 +54,7 @@ icon.version.control.hijack.undo = undo_hijack.png
 icon.folder.new = folder_add.png
 icon.console = monitor.png
 
-icon.datatree.node.domain.file = unknownFile.gif
+icon.datatree.node.domain.file = icon.domain.file.uknown
 icon.datatree.node.domain.folder.closed = icon.folder.closed
 icon.datatree.node.domain.folder.open = icon.folder.open
 

Ghidra/Framework/Project/src/main/java/ghidra/framework/main/projectdata/actions/ProjectDataPasteLinkAction.java

@@ -28,11 +28,11 @@ import ghidra.framework.main.datatree.*;
 import ghidra.framework.model.DomainFile;
 import ghidra.framework.model.DomainFolder;
 import ghidra.util.Msg;
+import resources.Icons;
 import resources.MultiIcon;
-import resources.ResourceManager;
 
 public class ProjectDataPasteLinkAction extends ProjectTreeAction {
-	private static Icon baseIcon = ResourceManager.loadImage("images/page_paste.png");
+	private static Icon baseIcon = Icons.PASTE_ICON;
 
 	public ProjectDataPasteLinkAction(String owner, String group) {
 		super("Paste Link", owner);

Ghidra/Framework/Project/src/main/java/ghidra/framework/model/DomainFile.java

@@ -22,13 +22,13 @@ import java.util.Map;
 
 import javax.swing.Icon;
 
+import generic.theme.GIcon;
 import ghidra.framework.client.NotConnectedException;
 import ghidra.framework.data.*;
 import ghidra.framework.store.*;
 import ghidra.util.InvalidNameException;
 import ghidra.util.exception.*;
 import ghidra.util.task.TaskMonitor;
-import resources.ResourceManager;
 
 /**
  * <code>DomainFile</code> provides a storage interface for project files.  A 
@@ -38,8 +38,7 @@ import resources.ResourceManager;
  */
 public interface DomainFile extends Comparable<DomainFile> {
 
-	public static final Icon UNSUPPORTED_FILE_ICON =
-		ResourceManager.loadImage("images/unknownFile.gif");
+	public static final Icon UNSUPPORTED_FILE_ICON = new GIcon("icon.domain.file.uknown");
 
 	/**
 	* Use with getDomainObject to request the default version.  The default version is
@@ -96,7 +95,7 @@ public interface DomainFile extends Comparable<DomainFile> {
 	 * @return remote Ghidra URL for this file or null
 	 */
 	public URL getSharedProjectURL();
-	
+
 	/**
 	 * Returns the local storage location for the project that this DomainFile belongs to.
 	 * @return the location