mirror/buildroot
1
0
Fork 0
mirror of https://gitlab.com/buildroot.org/buildroot.git synced 2026-09-09 16:01:54 -09:00
Code Issues Packages Projects Releases Wiki Activity

paclage/ace: explain why we use C++ pre-processor flags for C++ flags

Browse Source 
Commit e8011a08b6 (package/ace: needs C++11) did not explain why it
passed C++ flags via the pre-processor flags rather than as C++ flags
(via ACE's CCFLAGS).

This caused some head-scratching when reviewing and applying
803247337d (package/ace: fix build failure due to gcc bug 101915).

Add a comment to try and explain the non-standard use of pre-processor
flags to pass actual C++ flags.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc; Weber, Matthew L Collins <Matthew.Weber@collins.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
(cherry picked from commit b717880f1f)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
Yann E. MORIN
2022-08-14 15:29:01 +02:00
committed by Peter Korsgaard
parent 6757c071ef
commit 2a66954390
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
package/ace/ace.mk
View File

@@ -23,6 +23,9 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_101915),y)
ACE_CPPFLAGS += -O0
endif
# ACE uses DEFFLAGS as C++ pre-processor flags, and CCFLAGS as the C++ flags.
# Ace passes the pre-processor flags after the C++ flags, so we pass our
# C++ flags as pre-processor flags, via DEFFLAGS.
ACE_MAKE_OPTS = \
ACE_ROOT="$(@D)" \
DEFFLAGS="$(ACE_CPPFLAGS)"