mirror/buildroot
1
0
Fork 0
mirror of https://gitlab.com/buildroot.org/buildroot.git synced 2026-09-08 23:51:08 -09:00
Code Issues Packages Projects Releases Wiki Activity

Makefile: workaround make 4.3 issue for 'printvars and 'show-vars'

Browse Source 
Event though the bug with make 4.3 has been reported and fixed, there
has not been a release of make with the fix for a long time, see [1].

As the root cause seems the 'filter' command cannot handle large
chunks of data, like .VARIABLES, we can workaround the problem by
using a foreach command over .VARIABLES, then use the filter command.

It might not be logical to program it that way, but at least the
functionality is now usable.

[1] https://savannah.gnu.org/bugs/?59093#comment10

Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
[yann.morin.1998@free.fr: add comment to reference the bug]
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
(cherry picked from commit 5c54c3ef3d)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
Roosen Henri
2022-07-29 21:49:33 +00:00
committed by Peter Korsgaard
parent d7da4a9912
commit 767b986c4a
1 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
Makefile
View File

@@ -1051,23 +1051,19 @@ ifeq ($(NEED_WRAPPER),y)
$(Q)$(TOPDIR)/support/scripts/mkmakefile $(TOPDIR) $(O)
endif
.PHONY: check-make-version
check-make-version:
ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3),)
@echo "Make 4.3 doesn't support 'printvars' and 'show-vars' recipes"
@exit 1
endif
# printvars prints all the variables currently defined in our
# Makefiles. Alternatively, if a non-empty VARS variable is passed,
# only the variables matching the make pattern passed in VARS are
# displayed.
# show-vars does the same, but as a JSON dictionnary.
#
# Note: we iterate of .VARIABLES and filter each variable individually,
# to workaround a bug in make 4.3; see https://savannah.gnu.org/bugs/?59093
.PHONY: printvars
printvars: check-make-version
printvars:
@:
$(foreach V, \
$(sort $(filter $(VARS),$(.VARIABLES))), \
$(sort $(foreach X, $(.VARIABLES), $(filter $(VARS),$(X)))), \
$(if $(filter-out environment% default automatic, \
$(origin $V)), \
$(if $(QUOTED_VARS),\
@@ -1075,13 +1071,14 @@ printvars: check-make-version
$(info $V=$(if $(RAW_VARS),$(value $V),$($V))))))
# ')))) # Syntax colouring...
# See details above, same as for printvars
.PHONY: show-vars
show-vars: VARS?=%
show-vars: check-make-version
show-vars:
@:
$(info $(call clean-json, { \
$(foreach V, \
$(sort $(filter $(VARS),$(.VARIABLES))), \
$(sort $(foreach X, $(.VARIABLES), $(filter $(VARS),$(X)))), \
$(if $(filter-out environment% default automatic, $(origin $V)), \
"$V": { \
"expanded": $(call mk-json-str,$($V))$(comma) \