mirror/buildroot
1
0
Fork 0
mirror of https://gitlab.com/buildroot.org/buildroot.git synced 2026-09-30 05:51:45 -09:00
Code Issues Packages Projects Releases Wiki Activity

package/taglib: needs gcc >= 7

Browse Source 
Fixes a build error caught by the Gitlab pipelines:

/builds/bkuhls/buildroot/br-test-pkg/bootlin-aarch64-glibc-old/build/taglib-2.3/taglib/mpeg/mpegfile.cpp:113:10:
 error: expected primary-expression before ‘const’
       if(const Header header(&file, headerOffset + i, true); header.isValid()) {

which was introduced by code format changes in upstream commit
dfe2aa5253
which was first released with taglib 2.0, added to buildroot with commit
9cd3464afa.

This "init-statement" C++17 language feature was described in proposal
P0305R1, and according to
https://en.cppreference.com/cpp/compiler_support/17, this feature was
only supported in gcc starting from gcc 7.x.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
(cherry picked from commit d16e4939ca)
Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
This commit is contained in:
Bernd Kuhls
2026-07-24 18:48:28 +02:00
committed by Raphaël Mélotte
parent 8480e7ba01
commit a204f52222
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
package/gstreamer1/gst1-plugins-good/Config.in
View File

@@ -403,13 +403,15 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SPEEX
config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TAGLIB config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TAGLIB
bool "taglib" bool "taglib"
depends on BR2_INSTALL_LIBSTDCPP depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
depends on BR2_USE_WCHAR depends on BR2_USE_WCHAR
select BR2_PACKAGE_TAGLIB select BR2_PACKAGE_TAGLIB
help help
Taglib tagging plugin library Taglib tagging plugin library
comment "taglib needs a toolchain w/ C++, wchar" comment "taglib needs a toolchain w/ C++, wchar, gcc >= 7"
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
|| !BR2_TOOLCHAIN_GCC_AT_LEAST_7
config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TWOLAME config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TWOLAME
bool "twolame" bool "twolame"

6
package/taglib/Config.in
View File

@@ -1,6 +1,7 @@
config BR2_PACKAGE_TAGLIB config BR2_PACKAGE_TAGLIB
bool "taglib" bool "taglib"
depends on BR2_INSTALL_LIBSTDCPP depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
depends on BR2_USE_WCHAR depends on BR2_USE_WCHAR
select BR2_PACKAGE_UTFCPP select BR2_PACKAGE_UTFCPP
help help
@@ -12,5 +13,6 @@ config BR2_PACKAGE_TAGLIB
http://taglib.org/ http://taglib.org/
comment "taglib needs a toolchain w/ C++, wchar" comment "taglib needs a toolchain w/ C++, wchar, gcc >= 7"
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
|| !BR2_TOOLCHAIN_GCC_AT_LEAST_7