mirror of
https://gitlab.com/buildroot.org/buildroot.git
synced 2026-09-09 16:01:54 -09:00
3b7c7e6106
Commit134900401f(support/scripts/fix-rpath: parallelize patching files) broke the rpath fixup, because it improperly quoted or expanded variables: - $@ was expanded in the main() context, rather than in the sub-bash as expected, propagating incorrect parameters to patch_file(); - an array was passed without array expansion, so only the first item was passed; that was in turn assigned to a string, anyway loosign the array. Liuckily, we only ever put a single item in that array, so that worked by chance. We fix that by inverting the parameters to patch_elf(), where the extra args are passed last, so we can put as many we want in the future. We also pass every variables as positional parameters outside the bash -c command, which allows us proper quoting of all variables, specifically of the extra args array which now comes last. The ultralong line was split, too, in a hopefully easier-to-read form. Fixing all that also required fixing the many shellcheck issues at the same time (wome were pre-existing before134900401f). While at it, expand two TABs into spaces like the rest of the script. Note: shellcheck does not seem to warn when a variable expansion will be used as the command to run, i.e. ${PATCHELF} does not trigger the quoting error. Still, for consistency, we also double-quote it (we know it is a single word, as it is already double-quoted once in the script). Fixes:134900401fCc: Victor Dumas <dumasv.dev@gmail.com> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Buildroot is a simple, efficient and easy-to-use tool to generate embedded Linux systems through cross-compilation. The documentation can be found in docs/manual. You can generate a text document with 'make manual-text' and read output/docs/manual/manual.text. Online documentation can be found at http://buildroot.org/docs.html To build and use the buildroot stuff, do the following: 1) run 'make menuconfig' 2) select the target architecture and the packages you wish to compile 3) run 'make' 4) wait while it compiles 5) find the kernel, bootloader, root filesystem, etc. in output/images You do not need to be root to build or run buildroot. Have fun! Buildroot comes with a basic configuration for a number of boards. Run 'make list-defconfigs' to view the list of provided configurations. Please feed suggestions, bug reports, insults, and bribes back to the buildroot mailing list: buildroot@buildroot.org You can also find us on #buildroot on OFTC IRC. If you would like to contribute patches, please read https://buildroot.org/manual.html#submitting-patches