mirror of
https://gitlab.com/buildroot.org/buildroot.git
synced 2026-09-09 07:51:59 -09:00
a344a5b7cb
Commit5c54c3ef3d(Makefile: workaround make 4.3 issue for 'printvars and 'show-vars') did not fully fix the show-vars case, which still segfaults. Overall, show-vars generates a JSON blurb. That is supposed to be machine-readable, so we do not care that the variables are sorted, so we get rid of it to (slightly) simplify the code. Then, we currently iterate twice on the list of variables: the first one to filter-out the 'internal' variables, and the second one to filter only the variables matching the pattern. We can do away by iterating only once, and applying both filters at once. Since we now have an 'and' condition, we can take advantage of it: when none of the items in $(and) are empty, $(and) evaluates to the last item, while it evaluates to empty if any of the items is empty. So we can coalesce the $(if) and $(and) together: $(if $(and a,b),c) is equivalent to: $(and a,b,c) ; this gains us one parentheses depth. Finally, the cause for the segfault is an overly-long call to $(info). Reducing that is not easy: we want to call clean-json on the whole of the JSON blurb, so we can't emit the individual variables one by one, or the trailing comma would not be trimmed away. So, we go crazy: we just output each word from clean-json with $(info). We can do that, because mk-json-str transforms all spaces in a string to an escaped UTF-8 sequence, so we will never have spaces in values; the keys are the variables, so they won't have spaces either; spaces in the rest of the JSON blurb are totally optional, so we don't care how many there are. We know there are spaces, because we explicitly introduce some (after "expanded" or "raw", for example), so we should never hit a too-big word for $(info) to print. Thanks to Henri for the suggestion to push $(info) further inside the macro. Reported-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> Cc: Roosen Henri <Henri.Roosen@ginzinger.com> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Tested-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> (cherry picked from commit83f71e7ceb) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Buildroot is a simple, efficient and easy-to-use tool to generate embedded Linux systems through cross-compilation. The documentation can be found in docs/manual. You can generate a text document with 'make manual-text' and read output/docs/manual/manual.text. Online documentation can be found at http://buildroot.org/docs.html To build and use the buildroot stuff, do the following: 1) run 'make menuconfig' 2) select the target architecture and the packages you wish to compile 3) run 'make' 4) wait while it compiles 5) find the kernel, bootloader, root filesystem, etc. in output/images You do not need to be root to build or run buildroot. Have fun! Buildroot comes with a basic configuration for a number of boards. Run 'make list-defconfigs' to view the list of provided configurations. Please feed suggestions, bug reports, insults, and bribes back to the buildroot mailing list: buildroot@buildroot.org You can also find us on #buildroot on OFTC IRC. If you would like to contribute patches, please read https://buildroot.org/manual.html#submitting-patches