mirror/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-09-28 17:11:11 -09:00
Code Issues Packages Projects Releases Wiki Activity

more wiring in

Browse Source
This commit is contained in:
caheckman
2020-09-09 12:00:02 -04:00
parent 09fe23bfa4
commit 74103976a1
8 changed files with 24 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Ghidra/Features/Decompiler/certification.manifest
View File

@@ -1,4 +1,5 @@
##VERSION: 2.0
##MODULE IP: Crystal Clear Icons - LGPL 2.1
##MODULE IP: FAMFAMFAM Icons - CC 2.5
##MODULE IP: Oxygen Icons - LGPL 3.0
##MODULE IP: Tango Icons - Public Domain
@@ -53,4 +54,6 @@ src/main/help/help/topics/DecompilePlugin/images/Structnotapplied.png||GHIDRA|||
src/main/help/help/topics/DecompilePlugin/images/camera-photo.png||Tango Icons - Public Domain|||Tango|END|
src/main/help/help/topics/DecompilePlugin/images/decompileFunction.gif||GHIDRA||reviewed||END|
src/main/help/help/topics/DecompilePlugin/images/page_edit.png||FAMFAMFAM Icons - CC 2.5||||END|
src/main/help/help/topics/DecompilePlugin/images/page_white_copy.png||FAMFAMFAM Icons - CC 2.5||||END|
src/main/help/help/topics/DecompilePlugin/images/reload3.png||Crystal Clear Icons - LGPL 2.1||||END|
src/main/resources/images/decompileFunction.gif||GHIDRA||reviewed||END|

9
Ghidra/Features/Decompiler/src/main/doc/decompileplugin.xml
View File

@@ -3367,6 +3367,15 @@
generally where the variable is on the left-hand side of an assignment expression,
is highlighted in a different color. If the variable is written on multiple merging
control-flow paths, no written token is highlighted.
</para>
<para>
In the following example, the token representing the first write to the
variable <emphasis>a</emphasis> is selected when Def-Use is chosen.
<mediaobject>
<imageobject>
<imagedata fileref="images/Defuse.png" width="100%" contentwidth="3.8462in" contentdepth="2.8558in" align="center"/>
</imageobject>
</mediaobject>
</para></listitem>
</varlistentry>
<varlistentry>

2
Ghidra/Features/Decompiler/src/main/doc/decompileplugin_html.xsl
View File

@@ -52,5 +52,5 @@
<xsl:param name="admon.textlabel" select="0"/> <!-- Don't display title for important/note tags -->
<!-- <xsl:param name="admon.graphics.path" select="shared/"/> -->
<xsl:param name="admon.graphics.path" select="'../../shared/'"/>
</xsl:stylesheet>

BIN
Ghidra/Features/Decompiler/src/main/help/help/topics/DecompilePlugin/images/page_white_copy.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 309 B

BIN
Ghidra/Features/Decompiler/src/main/help/help/topics/DecompilePlugin/images/reload3.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 979 B

21
Ghidra/Features/Decompiler/src/main/java/ghidra/app/plugin/core/comments/DecompilerCommentsActionFactory.java
View File

@@ -1,6 +1,5 @@
/* ###
* IP: GHIDRA
* REVIEWED: YES
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,19 +15,19 @@
*/
package ghidra.app.plugin.core.comments;
import ghidra.app.context.ListingActionContext;
import ghidra.app.context.ProgramLocationActionContext;
import ghidra.app.decompiler.DecompilerLocation;
import ghidra.app.plugin.core.decompile.DecompilerActionContext;
import ghidra.program.model.address.Address;
import ghidra.program.model.listing.CodeUnit;
import ghidra.program.util.*;
import ghidra.util.HelpLocation;
import java.awt.event.KeyEvent;
import docking.ActionContext;
import docking.action.*;
import ghidra.app.context.ListingActionContext;
import ghidra.app.context.ProgramLocationActionContext;
import ghidra.app.decompiler.DecompilerLocation;
import ghidra.app.plugin.core.decompile.DecompilerActionContext;
import ghidra.app.util.HelpTopics;
import ghidra.program.model.address.Address;
import ghidra.program.model.listing.CodeUnit;
import ghidra.program.util.*;
import ghidra.util.HelpLocation;
public class DecompilerCommentsActionFactory extends CommentsActionFactory {
@@ -64,7 +63,7 @@ public class DecompilerCommentsActionFactory extends CommentsActionFactory {
this.commentType = commentType;
setPopupMenuData(new MenuData(new String[] { "Comments",
actionName + "..." }, "comments"));
setHelpLocation(new HelpLocation("CommentsPlugin", "Edit_Comments"));
setHelpLocation(new HelpLocation(HelpTopics.DECOMPILER, "ActionComments"));
}
protected int getEditCommentType(ActionContext context) {

2
Ghidra/Features/Decompiler/src/main/java/ghidra/app/plugin/core/decompile/DecompilerProvider.java
View File

@@ -172,7 +172,7 @@ public class DecompilerProvider extends NavigatableComponentProviderAdapter
setWindowMenuGroup("Decompile");
setDefaultWindowPosition(WindowPosition.RIGHT);
createActions(isConnected);
setHelpLocation(new HelpLocation(plugin.getName(), "Decompiler"));
setHelpLocation(new HelpLocation(HelpTopics.DECOMPILER, "DecompilerIntro"));
addToTool();
redecompileUpdater = new SwingUpdateManager(500, 5000, () -> doRefresh());

1
Ghidra/Features/Decompiler/src/main/java/ghidra/app/plugin/core/decompile/actions/OverridePrototypeAction.java
View File

@@ -260,7 +260,6 @@ public class OverridePrototypeAction extends AbstractDecompilerAction {
String signature = generateSignature(op, name);
PluginTool tool = context.getTool();
ProtoOverrideDialog dialog = new ProtoOverrideDialog(tool, func, signature, conv);
// dialog.setHelpLocation( new HelpLocation( getOwner(), "Edit_Function_Signature" ) );
tool.showDialog(dialog);
FunctionDefinition fdef = dialog.getFunctionDefinition();
if (fdef == null) {