Commit Graph

17319 Commits

Author SHA1 Message Date
vigneshakaviki
5259f4b7ae GP-0: Fix VarargsFilter doing nothing due to firstVarArgSlot never being set
When the Function Editor assigns parameter storage, PrototypePieces.firstVarArgSlot
was always left at -1, causing VarargsFilter.filter() to unconditionally return false.
Any .cspec rule using <varargs/> (e.g. MSP430's goto_stack for the last fixed arg) had
no effect when storage was (re-)assigned via the UI.

Fix: add a getStorageLocations overload that accepts an isVarArgs flag. When true,
firstVarArgSlot is set to proto.intypes.size() — meaning all supplied parameters are
non-optional and the first vararg slot follows immediately after the last one.
FunctionData.updateParameterAndReturnStorage() now passes hasVarArgs to this overload,
so VarargsFilter-based rules fire correctly.

Fixes #9091

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-05 09:58:10 -04:00
Ryan Kurtz
49155d2384 Merge branch 'GP-0_ryanmkurtz_PR-9156_villesundell_pyghidra-typo' 2026-05-05 05:00:42 -04:00
Ryan Kurtz
a0786100c7 Merge remote-tracking branch
'origin/GP-6784_Dan_PR-9147_SetoKaiba_master' (Closes #9146,
Closes #9147)
2026-05-05 04:44:22 -04:00
Dan
1b44ac3559 GP-6784: Certify 2026-05-04 19:21:43 +00:00
ghidra1
dee3703ef6 Merge remote-tracking branch 'origin/Ghidra_12.1' 2026-05-04 14:59:19 -04:00
ghidra1
39c3a2dad1 Merge remote-tracking branch 'origin/GP-1_ghidragon_test_fixes_4_22_26' 2026-05-04 14:53:08 -04:00
Ville Sundell
6ebedafffc README: pyGhidraRun -> pyghidraRun
The actual file seems to be "pyghidraRun" instead of "pyGhidraRun",
this is important on UNIX systems, as filenames are case sensitive.
2026-05-04 21:50:37 +03:00
ghidra1
2f2b76910f Merge remote-tracking branch 'origin/GP-6719_ghidra1_GhidraServerRMISerializationFilters--SQUASHED' into patch 2026-05-04 14:44:30 -04:00
Ryan Kurtz
f24e814d1b Merge remote-tracking branch 'origin/Ghidra_12.1' 2026-05-04 14:13:50 -04:00
Ryan Kurtz
ff0789ff16 Merge remote-tracking branch 'origin/GP-0-dragonmacher-test-fixes-4-4-26' into Ghidra_12.1 2026-05-04 14:06:48 -04:00
dragonmacher
3e781767e1 Test fixes 2026-05-04 14:00:58 -04:00
Ryan Kurtz
3262c7f1bf GP-0: Fixing javadoc for Listing.getNumCodeUnits() (Closes #9148) 2026-05-04 11:51:39 -04:00
Ryan Kurtz
ec93813290 Merge remote-tracking branch 'origin/GP-6781_Dan_fixSnapshotTableNPE' 2026-05-04 11:00:30 -04:00
Ryan Kurtz
8a095c5982 Merge remote-tracking branch 'origin/GP-0_Dan_fixGdbTypesIgnoreMypy' 2026-05-04 10:59:31 -04:00
Ryan Kurtz
1d4f676603 Merge remote-tracking branch 'origin/GP-0_Dan_fixAnotherVersion' 2026-05-04 10:58:00 -04:00
Dan
027e57c015 GP-0: Remove a:None argument that mypy incorrectly complains about. 2026-05-04 14:57:03 +00:00
Dan
25674f95e2 GP-6781: Fix NPE in Snapshot table 2026-05-04 14:48:37 +00:00
Dan
49477848e2 GP-0: Fix another version number. 2026-05-04 14:46:13 +00:00
ghidra1
e04d9ec716 GP-6719 Improved Ghidra Server RMI deserialization filter and added client-side module-based RMI deserialization filter. 2026-05-04 10:22:51 -04:00
Ryan Kurtz
6e3681cce2 Merge remote-tracking branch 'origin/GP-0_Dan_fixTests-versions' 2026-05-04 10:12:12 -04:00
Dan
076fe2b281 GP-0: Update Debugger versions. 2026-05-04 14:04:14 +00:00
Ryan Kurtz
60c32f5ffc Merge remote-tracking branch 'origin/GP-6691-dragonmacher-location-refs-field-access--SQUASHED' 2026-05-04 05:01:57 -04:00
ghidra1
a86a9ce474 Merge remote-tracking branch 'origin/patch' into Ghidra_12.1 2026-05-01 18:21:26 -04:00
dragonmacher
0999e6b9a4 GP-6691 - Data Type Finder - Updated search results to include the field name if one is available. Added a new table column to show just the field name. 2026-05-01 17:39:14 -04:00
ghidra1
3366060868 Merge remote-tracking branch 'origin/GP-1-dragonmacher-fg-removed-transformed-map' into patch 2026-05-01 17:13:00 -04:00
dragonmacher
864d5d2cf4 Removed uses of TransformedMap 2026-05-01 17:10:26 -04:00
Ryan Kurtz
5a142c25da Merge remote-tracking branch 'origin/GP-6651-dragonmacher-table-navigation' 2026-05-01 07:10:57 -04:00
Ryan Kurtz
4c41c2dca1 Merge remote-tracking branch 'origin/Ghidra_12.1' 2026-05-01 07:09:44 -04:00
Ryan Kurtz
7058a36d40 Merge remote-tracking branch 'origin/gp-6766_ghidorahrex_MIPS_movn_operand_fix' into Ghidra_12.1 2026-05-01 07:01:29 -04:00
dragonmacher
1c51e3eb43 GP-6651 - Updated tables to support navigation when the table rows are
from different programs
2026-04-30 14:15:09 -04:00
Ryan Kurtz
7db1b83ff5 Merge remote-tracking branch 'origin/GP-6755-dragonmacher-dt-preview-fix' 2026-04-30 12:13:06 -04:00
Ryan Kurtz
ae8ec35980 Merge remote-tracking branch 'origin/GP-6674-dragonmacher-fg-cursor-update' 2026-04-30 12:11:51 -04:00
Ryan Kurtz
84fbc2f194 Merge remote-tracking branch 'origin/Ghidra_12.1' 2026-04-30 12:10:19 -04:00
Ryan Kurtz
be12bbd68a Merge remote-tracking branch 'origin/GP-6749-dragonmacher-dt-filter-fix' into Ghidra_12.1 2026-04-30 12:07:06 -04:00
dragonmacher
0a6606a2ac GP-6749 - Data Type Manager - Fixed the filter and added an 'Other'
category
2026-04-30 11:46:55 -04:00
Ryan Kurtz
2a96e9078f Merge remote-tracking branch 'origin/GP-6756-dragonmacher-save-as-folder-issue' into Ghidra_12.1 2026-04-30 11:42:50 -04:00
Ryan Kurtz
b3eef5912c Merge remote-tracking branch 'origin/GP-0-dragonmacher-test-fixes-4-30-26' 2026-04-30 11:17:21 -04:00
dragonmacher
a47246aa7a Test fixes 2026-04-30 11:04:22 -04:00
Seto
40f46a0841 fix: ensure vertical scrolling occurs during VT buffer wrap regardless of cursor visibility 2026-04-30 16:35:31 +08:00
Seto
0f939eeffc fix: improve VT buffer scrolling logic to respect scroll regions and add support for the HVP escape sequence 2026-04-30 16:12:13 +08:00
dragonmacher
663c21df19 GP-6674 - Function Graph - Fixed cursor not updating when a node is
selected
2026-04-29 19:12:48 -04:00
dragonmacher
09de38f88c GP-6755 - Data Type Manager - Updated preview window to clear when
switching programs
2026-04-29 18:19:08 -04:00
ghidorahrex
d29a605572 GP-6766: Corrected operand ordering for MIPS16e movz and movn 2026-04-29 20:15:19 +00:00
dragonmacher
4fd80959b7 GP-6756 - Fixed 'Save As' dialog not allowing users to select a folder 2026-04-29 14:15:55 -04:00
Ryan Kurtz
4e83ee7ce4 Merge remote-tracking branch 'origin/Ghidra_12.1' 2026-04-29 10:26:01 -04:00
Ryan Kurtz
e115cd1098 GP-6754: Throw Error instead of System.exit() 2026-04-29 10:22:30 -04:00
Ryan Kurtz
b337505cc3 Merge remote-tracking branch 'origin/Ghidra_12.1' 2026-04-29 09:36:58 -04:00
Ryan Kurtz
dbce976b21 Merge remote-tracking branch 'origin/GP-0_ghidorahrex_8051_fix' into Ghidra_12.1 2026-04-29 09:29:07 -04:00
ghidorahrex
9e18f9439e GP-0: Fixed missing define statement 2026-04-29 12:40:29 +00:00
Ryan Kurtz
7118ef9c4c Merge remote-tracking branch 'origin/GP-6667_dev747368_rust_dwarf_empty_func_params' 2026-04-29 07:08:02 -04:00